search

openshift / external-dns-operator

The ExternalDNS Operator provides simplified ExternalDNS controller management.
Apache License 2.0
22 stars 33 forks source link

Enable prometheus metrics scraping #156

Closed alebedev87 closed 2 years ago

alebedev87 commented 2 years ago

Result: image

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/external-dns-operator/blob/main/OWNERS)~~ [alebedev87] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
alebedev87 commented 2 years ago

/assign @DhritiShikhar

DhritiShikhar commented 2 years ago

Should there be any tests for this @alebedev87 ?

arjunrn commented 2 years ago

Do you also want to explicity set the metrics port while initializing the operator so that the configuration matches what is currently implicit.

alebedev87 commented 2 years ago

@DhritiShikhar : for the e2e test we'd need a reliable way of verifying the target creation in prometheus. Will try to find something.

DhritiShikhar commented 2 years ago

/lgtm

alebedev87 commented 2 years ago

As discussed with Dhriti, the e2e testing is possible but quite heavy. Prometheus targets are not exposed on the Kubernetes level (CRs or ConfigMaps/Secrets), they have to be retrieved from the prometheus API which most often is queried by exec inf into the prometheus POD.

alebedev87 commented 2 years ago

/assign @quarterpin

quarterpin commented 2 years ago

/label qe-approved

alebedev87 commented 2 years ago

/assign @xenolinux

CFields651 commented 2 years ago

/label px-approved

alebedev87 commented 2 years ago

/label docs-approved

Don't expect any docs update for the built-in controller-runtime metrics.

openshift-ci[bot] commented 2 years ago

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).