Bug 2091602: Support AWS GovCloud

[alebedev87]

Main changes related to AWS Gov Cloud support:

• pkg/operator/controller/externaldns/credentials_request.go#createProviderConfig() - added the AWS Gov partition to the hosted zone ARN
• pkg/operator/controller/externaldns/pod.go#fillAWSFileds() - added AWS_REGION env variable as required by the upstream

The rest is the refactoring I could not pass by:

• pkg/operator/controller/externaldns/credentials-request.go renamed to pkg/operator/controller/externaldns/credentials_request.go
• pkg/operator/controller/externaldns/credentials-request_test.go renamed to pkg/operator/controller/externaldns/credentials_request_test.go
• pkg/operator/controller/externaldns/credentials_request.go - methods functions organized - reconciler methods up, secondary functions down
• pkg/operator/controller/externaldns/credentials_request.go#externalDNSCredentialsRequestChanged() - was just not good, wasn't comparing service accounts, secrets
• pkg/operator/controller/externaldns/credentials_request_test.go was basically rewritten, better to review it as a new file
• pkg/operator/controller/utils/test/builders.go was added to greatly simplify the generation of test ExternalDNS CRs

[openshift-ci[bot]]

@alebedev87: Bugzilla bug 2091602 is in a bug group that is not in the allowed groups for this repo. Allowed groups for this repo are:

• qe_staff
• redhat

In response to [this](https://github.com/openshift/external-dns-operator/pull/160): >Bug 2091602: Support AWS Gov Cloud Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/external-dns-operator/blob/main/OWNERS)~~ [alebedev87] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

[alebedev87]

/bugzilla refresh

[openshift-ci[bot]]

@alebedev87: This pull request references Bugzilla bug 2091602, which is invalid:

• expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/external-dns-operator/pull/160#issuecomment-1143269152): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[alebedev87]

/assign @quarterpin

[alebedev87]

/bugzilla refresh

[openshift-ci[bot]]

@alebedev87: This pull request references Bugzilla bug 2091602, which is invalid:

• expected the bug to target the "4.11.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/external-dns-operator/pull/160#issuecomment-1143583463): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[alebedev87]

/bugzilla refresh

[openshift-ci[bot]]

@alebedev87: This pull request references Bugzilla bug 2091602, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target release (4.11.0) matches configured target release for branch (4.11.0) * bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @quarterpin

In response to [this](https://github.com/openshift/external-dns-operator/pull/160#issuecomment-1143584594): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

[thejasn]

/lgtm

[CFields651]

/label px-approved

[quarterpin]

/label qe-approved Verified via pre-merge test process. For more details refer to: https://bugzilla.redhat.com/show_bug.cgi?id=2091602#c2

[xenolinux]

/label docs-approved

[alebedev87]

main moved from the time the last run was made, so after all the labels were given the run failed due to the changes made in between:

-   SecurityContext: nil,
+   SecurityContext: s"&SecurityContext{Capabilities:&Capabilities{Add:[],Drop:[ALL],},Privileged:*false,SELinuxOptions:nil,RunAsUser:nil,RunAsNonRoot:*true,ReadOnlyRootFilesystem:nil,AllowPrivilegeEscalation:*false,RunAsGroup:nil,ProcMount:nil,WindowsOptions:nil,SeccompProfile:"...,

Rebased and added the missing security context to the unit test. No functional changes - all the labels can be set back.

[thejasn]

/lgtm

[openshift-ci[bot]]

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[openshift-ci[bot]]

@alebedev87: All pull requests linked via external trackers have merged:

• openshift/external-dns-operator#160

Bugzilla bug 2091602 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/external-dns-operator/pull/160): >Bug 2091602: Support AWS GovCloud Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.