openshift / external-dns-operator

The ExternalDNS Operator provides simplified ExternalDNS controller management.
Apache License 2.0
22 stars 33 forks source link

Update the operand image to catch up on 2 upstream fixes #167

Closed alebedev87 closed 1 year ago

alebedev87 commented 1 year ago

Upstream fixes:

alebedev87 commented 1 year ago

/hold

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/external-dns-operator/blob/main/OWNERS)~~ [alebedev87] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
alebedev87 commented 1 year ago

/retest

alebedev87 commented 1 year ago

/retest

alebedev87 commented 1 year ago

OCP 4.12 is already used as the cluster version for CI. OLM catalogsource POD is not ready for the enforced Pod Security Profile:

message: 'couldn''t ensure registry server - error ensuring pod: : error creating
    new pod: oo-tdm8q-: pods "oo-tdm8q-zsgcn" is forbidden: violates PodSecurity "restricted:v1.24":
    allowPrivilegeEscalation != false (container "registry-server" must set securityContext.allowPrivilegeEscalation=false),
    unrestricted capabilities (container "registry-server" must set securityContext.capabilities.drop=["ALL"]),
    runAsNonRoot != true (pod or container "registry-server" must set securityContext.runAsNonRoot=true),
    seccompProfile (pod or container "registry-server" must set securityContext.seccompProfile.type
    to "RuntimeDefault" or "Localhost")'
alebedev87 commented 1 year ago

/unhold

quarterpin commented 1 year ago

/label qe-approved

alebedev87 commented 1 year ago

Infoblox test:

export DNS_PROVIDER=INFOBLOX
$ make test-e2e
go test \
-ldflags "-X github.com/openshift/external-dns-operator/pkg/version.SHORTCOMMIT=1b2bc9e -X github.com/openshift/external-dns-operator/pkg/version.COMMIT=1b2bc9ed59e7914af3345ca153cf84c17673c861" \
-timeout 1h \
-count 1 \
-v \
-tags e2e \
-run "" \
./test/e2e

Ensuring hosted zone: 1659079833.1b2bc9e.example-test.info
=== RUN   TestOperatorAvailable
--- PASS: TestOperatorAvailable (2.25s)
=== RUN   TestExternalDNSWithRoute
--- PASS: TestExternalDNSWithRoute (46.39s)
=== RUN   TestExternalDNSRecordLifecycle
--- PASS: TestExternalDNSCustomIngress (17.00s)
=== RUN   TestExternalDNSWithRouteV1Alpha1
--- PASS: TestExternalDNSWithRouteV1Alpha1 (16.56s)
=== RUN   TestExternalDNSSecretCredentialUpdate
--- PASS: TestExternalDNSSecretCredentialUpdate (61.69s)
PASS
Deleting hosted zone: 1659079833.1b2bc9e.example-test.info
ok      github.com/openshift/external-dns-operator/test/e2e 230.372s
alebedev87 commented 1 year ago

GCP test:

$ export DNS_PROVIDER=GCP
$ make test-e2e
go test \
-ldflags "-X github.com/openshift/external-dns-operator/pkg/version.SHORTCOMMIT=1b2bc9e -X github.com/openshift/external-dns-operator/pkg/version.COMMIT=1b2bc9ed59e7914af3345ca153cf84c17673c861" \
-timeout 1h \
-count 1 \
-v \
-tags e2e \
-run "" \
./test/e2e

Ensuring hosted zone: 1659080887.1b2bc9e.example-test.info
=== RUN   TestOperatorAvailable
--- PASS: TestOperatorAvailable (2.25s)
=== RUN   TestExternalDNSWithRoute
--- PASS: TestExternalDNSWithRoute (16.29s)
=== RUN   TestExternalDNSRecordLifecycle
--- PASS: TestExternalDNSRecordLifecycle (76.28s)
=== RUN   TestExternalDNSCustomIngress
--- PASS: TestExternalDNSCustomIngress (17.21s)
=== RUN   TestExternalDNSWithRouteV1Alpha1
--- PASS: TestExternalDNSWithRouteV1Alpha1 (16.18s)
=== RUN   TestExternalDNSSecretCredentialUpdate
--- PASS: TestExternalDNSSecretCredentialUpdate (76.43s)
PASS
Deleting hosted zone: 1659080887.1b2bc9e.example-test.info
ok      github.com/openshift/external-dns-operator/test/e2e 212.040s
openshift-ci[bot] commented 1 year ago

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
alebedev87 commented 1 year ago

Oh, the OLM was fixed, nice :)

alebedev87 commented 1 year ago

/label docs-approved /label px-approved

No changes on this side

Miciah commented 1 year ago

/lgtm