Closed alebedev87 closed 1 year ago
@alebedev87: This pull request references Jira Issue OCPBUGS-91, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
/jira refresh
@alebedev87: This pull request references Jira Issue OCPBUGS-91, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.
Requesting review from QA contact: /cc @quarterpin
/assign @xenolinux
I'm going to do the first pass review but will put a hold until someone from NetEdge can do the final review. /hold
/assign
/assign /assign @brandisher
I like the changes to the format; that does make it a little clearer on where the limits apply. Readding lgtm.
/lgtm
@brandisher : thanks a lot for coming back to the PR and tagging it. I had to change the diff again after the discussion we had with @candita yesterday.
Can you, folks, have another look, please?
/check-required-labels
Looks good! /approve
/hold cancel
/refresh
Latest changes look good to me as well!
/lgtm
/retest
/assign @xenolinux
/assign @lihongan
/check-required-labels
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: alebedev87, candita
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/label px-approved
/label qe-approved
/bugzilla refresh
The requirements for Bugzilla bugs have changed (BZs linked to PRs on main branch need to target OCP 4.12), recalculating validity.
@openshift-bot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh
.
Retaining the bugzilla/valid-bug label as it was manually added.
/jira refresh
The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target OCP 4.12), recalculating validity.
@openshift-bot: This pull request references Jira Issue OCPBUGS-91, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
/jira refresh
@alebedev87: This pull request references Jira Issue OCPBUGS-91, which is valid.
Requesting review from QA contact: /cc @lihongan
/label docs-approved
@alebedev87: all tests passed!
Full PR test history. Your PR dashboard.
@alebedev87: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-91 has been moved to the MODIFIED state.
This PR adds a README chapter to document the limitation on the length of the domain names managed by
ExternalDNS
instances.