openshift / external-dns-operator

The ExternalDNS Operator provides simplified ExternalDNS controller management.
Apache License 2.0
25 stars 33 forks source link

OCPBUGS-91: document the domain name limitation #173

Closed alebedev87 closed 1 year ago

alebedev87 commented 2 years ago

This PR adds a README chapter to document the limitation on the length of the domain names managed by ExternalDNS instances.

openshift-ci-robot commented 2 years ago

@alebedev87: This pull request references Jira Issue OCPBUGS-91, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/external-dns-operator/pull/173): >This PR adds a README chapter to document the limitation on the length of the domain names managed by `ExternalDNS` instances. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
alebedev87 commented 2 years ago

/jira refresh

openshift-ci-robot commented 2 years ago

@alebedev87: This pull request references Jira Issue OCPBUGS-91, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.12.0) matches configured target version for branch (4.12.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @quarterpin

In response to [this](https://github.com/openshift/external-dns-operator/pull/173#issuecomment-1235629710): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
alebedev87 commented 2 years ago

/assign @xenolinux

brandisher commented 1 year ago

I'm going to do the first pass review but will put a hold until someone from NetEdge can do the final review. /hold

brandisher commented 1 year ago

/assign

candita commented 1 year ago

/assign /assign @brandisher

brandisher commented 1 year ago

I like the changes to the format; that does make it a little clearer on where the limits apply. Readding lgtm.

/lgtm

alebedev87 commented 1 year ago

@brandisher : thanks a lot for coming back to the PR and tagging it. I had to change the diff again after the discussion we had with @candita yesterday.

Can you, folks, have another look, please?

candita commented 1 year ago

/check-required-labels

candita commented 1 year ago

Looks good! /approve

candita commented 1 year ago

/hold cancel

candita commented 1 year ago

/refresh

brandisher commented 1 year ago

Latest changes look good to me as well!

/lgtm

brandisher commented 1 year ago

/retest

alebedev87 commented 1 year ago

/assign @xenolinux

alebedev87 commented 1 year ago

/assign @lihongan

candita commented 1 year ago

/check-required-labels

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87, candita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/external-dns-operator/blob/main/OWNERS)~~ [alebedev87,candita] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
CFields651 commented 1 year ago

/label px-approved

lihongan commented 1 year ago

/label qe-approved

openshift-bot commented 1 year ago

/bugzilla refresh

The requirements for Bugzilla bugs have changed (BZs linked to PRs on main branch need to target OCP 4.12), recalculating validity.

openshift-ci[bot] commented 1 year ago

@openshift-bot: No Bugzilla bug is referenced in the title of this pull request. To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Retaining the bugzilla/valid-bug label as it was manually added.

In response to [this](https://github.com/openshift/external-dns-operator/pull/173#issuecomment-1295182839): >/bugzilla refresh > >The requirements for Bugzilla bugs have changed (BZs linked to PRs on main branch need to target OCP 4.12), recalculating validity. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 year ago

/jira refresh

The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target OCP 4.12), recalculating validity.

openshift-ci-robot commented 1 year ago

@openshift-bot: This pull request references Jira Issue OCPBUGS-91, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/external-dns-operator/pull/173#issuecomment-1295190570): >/jira refresh > >The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target OCP 4.12), recalculating validity. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
alebedev87 commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@alebedev87: This pull request references Jira Issue OCPBUGS-91, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.13.0) matches configured target version for branch (4.13.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @lihongan

In response to [this](https://github.com/openshift/external-dns-operator/pull/173#issuecomment-1308432322): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
xenolinux commented 1 year ago

/label docs-approved

openshift-ci[bot] commented 1 year ago

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 year ago

@alebedev87: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-91 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/external-dns-operator/pull/173): >This PR adds a README chapter to document the limitation on the length of the domain names managed by `ExternalDNS` instances. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.