search

openshift / external-dns-operator

The ExternalDNS Operator provides simplified ExternalDNS controller management.
Apache License 2.0
22 stars 33 forks source link

Support Nodename for ExternalDNSServiceSourceOptions #189

Closed git001 closed 8 months ago

git001 commented 1 year ago

We need to add the machine names into a corporate DNS therefore would it be very helpfull to be able to use the node status for external DNS or some labels or annotations.

apiVersion: v1
kind: Node
metadata:
  annotations:
    k8s.ovn.org/host-addresses: '["10.x.x.x"]'
    # other annotations
  labels:
    kubernetes.io/hostname: mycluster-p8zqf-worker-chpgv
    # other labels
  name: mycluster-p8zqf-worker-chpgv
.......
status:
  addresses:
  - address: 10.x.x.x
    type: ExternalIP
  - address: 10.x.x.x
    type: InternalIP
  - address: mycluster-p8zqf-worker-chpgv
    type: Hostname
.......

Maybe this is already possible with hostnameAnnotation HostnameAnnotationPolicy but it looks to me that this annotation is only possible for the supported serviceTypes https://github.com/openshift/external-dns-operator/blob/fd1d055f84381bd12b431c071a3255c935fdbfe3/api/v1beta1/externaldns_types.go#L471

openshift-bot commented 1 year ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

alebedev87 commented 1 year ago

@git001 : you are right in your findings: the operator doesn't support the node source type for the moment. So, it's not currently possible to create DNS records backed up by the Node Kubernetes resource.

git001 commented 1 year ago

@alebedev87 thank you for the approval. Can we use this issue as a feature request or how is the process for that component to raise a FR?

openshift-bot commented 1 year ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

alebedev87 commented 1 year ago

/remove-lifecycle stale /remove-lifecycle rotten

alebedev87 commented 1 year ago

/remove-lifecycle stale

openshift-bot commented 11 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 10 months ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 9 months ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 9 months ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/external-dns-operator/issues/189#issuecomment-1712665330): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 8 months ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 8 months ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/external-dns-operator/issues/189#issuecomment-1762409766): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.