Closed scottd018 closed 1 year ago
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: scottd018 Once this PR has been reviewed and has the lgtm label, please assign candita for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
@scottd018: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/verify | 07f6aba75890d64394209f051722b0e8320d3382 | link | true | /test verify |
Full PR test history. Your PR dashboard.
Issues go stale after 90d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen
.
If this issue is safe to close now please do so with /close
.
/lifecycle stale
Stale issues rot after 30d of inactivity.
Mark the issue as fresh by commenting /remove-lifecycle rotten
.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen
.
If this issue is safe to close now please do so with /close
.
/lifecycle rotten /remove-lifecycle stale
Rotten issues close after 30d of inactivity.
Reopen the issue by commenting /reopen
.
Mark the issue as fresh by commenting /remove-lifecycle rotten
.
Exclude this issue from closing again by commenting /lifecycle frozen
.
/close
@openshift-bot: Closed this PR.
Fixes #190
This PR does the following:
spec.provider.aws.assumeRole.id
(AWS Role ARN) andspec.provider.aws.assumeRole.strategy
(type ofirsa
,kiam
, orkube2iam
)spec.provider.aws.assumeRole
is set to allow external-dns controller to update DNSeks.amazonaws.com/role-arn
service account annotation if IRSA is requestediam.amazonaws.com/role
if kiam/kube2iam is requested