openshift / external-dns-operator

The ExternalDNS Operator provides simplified ExternalDNS controller management.
Apache License 2.0
22 stars 33 forks source link

Azure Private DNS handling #197

Open git001 opened 10 months ago

git001 commented 10 months ago

This PR suggest that it's possible to manage also azure private dns zones with external-dns-operator (edo).
https://github.com/openshift/external-dns-operator/pull/89/files

When I run this command with the latest edo can I also see some private dns output.

F:\openshift>oc run ext-dns --image=quay.io/external-dns-operator/external-dns:latest -it --rm --command  -- bash

[root@ext-dns /]# external-dns --help 2>&1|egrep -i azure
                                 godaddy, google, azure, azure-dns,
                                 azure-private-dns, bluecat, cloudflare,
                                 only AzureDNS provider is using this flag);
  --azure-config-file="/etc/kubernetes/azure.json"
                                 When using the Azure provider, specify the
                                 Azure configuration file (required when
                                 --provider=azure
  --azure-resource-group=""      When using the Azure provider, override the
                                 Azure resource group to use (required when
                                 --provider=azure-private-dns)
  --azure-subscription-id=""     When using the Azure provider, specify the
                                 Azure configuration file (required when
                                 --provider=azure-private-dns)
  --azure-user-assigned-identity-client-id=""
                                 When using the Azure provider, override the

In the official doc is this not documented. Is the azure private DNS "just" not supported but possible or not available in the operator?

https://docs.openshift.com/container-platform/4.13/networking/external_dns_operator/nw-creating-dns-records-on-azure.html

What I understand in the CRD is the Azure private DNS not listed, right? https://github.com/openshift/external-dns-operator/blob/release-4.13/bundle/manifests/externaldns.olm.openshift.io_externaldnses.yaml#L228

alebedev87 commented 9 months ago

@git001: there is a documentation gap for the support of the private Azure zones indeed. From the API point of view, it's still the same provider: Azure. However the private zones set in .spec.zones will be configured with azure-private-dns provider flag as required by the upstream.

git001 commented 9 months ago

@alebedev87 thank you for the Update. I will test and write here what I have done and if it was working or not :smile:

openshift-bot commented 6 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 5 months ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

alebedev87 commented 5 months ago

/remove-lifecycle rotten

alebedev87 commented 2 months ago

@jmanthei : can you please file a bug for the doc gap about private Azure DNS zones?