search

openshift / external-dns-operator

The ExternalDNS Operator provides simplified ExternalDNS controller management.
Apache License 2.0
22 stars 33 forks source link

NE-1324: E2E tests for Assume Role in Shared VPC Cluster #198

Closed gcs278 closed 8 months ago

gcs278 commented 9 months ago

Add E2E tests for AssumeRole functionality added in https://github.com/openshift/external-dns-operator/pull/195/. It creates a ExternalDNS object with AssumeRole configured inside of a Shared VPC cluster. It then confirms that an example DNS record gets created in a targeted AWS account's hosted zone as well as it queries the DNS record inside the cluster to test end-to-end DNS record functionality.

This E2E test update is also dependent on https://github.com/openshift/release/pull/42894 which adds a new CI test job e2e-aws-shared-vpc-phz-operator to this repo. Without this, this new E2E test will be skipped.

Dependent on https://github.com/openshift/external-dns-operator/pull/195/ and will need rebase when it merges.

openshift-ci-robot commented 9 months ago

@gcs278: This pull request references NE-1324 which is a valid jira issue.

In response to [this](https://github.com/openshift/external-dns-operator/pull/198): >WIP >Dependent on https://github.com/openshift/external-dns-operator/pull/195/ and will need rebase when it merges. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 9 months ago

@gcs278: This pull request references NE-1324 which is a valid jira issue.

In response to [this](https://github.com/openshift/external-dns-operator/pull/198): >WIP >Dependent on https://github.com/openshift/external-dns-operator/pull/195/ and will need rebase when it merges. > >TODO: >- So the particular case when spec.provider.credentials.name has to be empty is not tested in this PR. Will it be in a follow up e2e PR? Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 9 months ago

@gcs278: This pull request references NE-1324 which is a valid jira issue.

In response to [this](https://github.com/openshift/external-dns-operator/pull/198): >Add E2E tests for AssumeRole functionality added in https://github.com/openshift/external-dns-operator/pull/195/. It creates a ExternalDNS object with AssumeRole configured inside of a Shared VPC cluster. It then confirms that an example DNS record gets created in a targeted AWS account's hosted zone as well as it queries the DNS record inside the cluster to test end-to-end DNS record functionality. > >This E2E test update is also dependent on https://github.com/openshift/release/pull/42894 which adds a new CI test job `e2e-aws-shared-vpc-phz-operator` to this repo. Without this, this new E2E test will be skipped. > >WIP: Dependent on https://github.com/openshift/external-dns-operator/pull/195/ and will need rebase when it merges. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 9 months ago

@gcs278: This pull request references NE-1324 which is a valid jira issue.

In response to [this](https://github.com/openshift/external-dns-operator/pull/198): >Add E2E tests for AssumeRole functionality added in https://github.com/openshift/external-dns-operator/pull/195/. It creates a ExternalDNS object with AssumeRole configured inside of a Shared VPC cluster. It then confirms that an example DNS record gets created in a targeted AWS account's hosted zone as well as it queries the DNS record inside the cluster to test end-to-end DNS record functionality. > >This E2E test update is also dependent on https://github.com/openshift/release/pull/42894 which adds a new CI test job `e2e-aws-shared-vpc-phz-operator` to this repo. Without this, this new E2E test will be skipped. > >Dependent on https://github.com/openshift/external-dns-operator/pull/195/ and will need rebase when it merges. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
alebedev87 commented 9 months ago

/assign

gcs278 commented 9 months ago

/test e2e-aws-shared-vpc-phz-operator

gcs278 commented 9 months ago

/retest

gcs278 commented 9 months ago

An error occurred (HostedZoneAlreadyExists) when calling the CreateHostedZone operation: A hosted zone has already been created with the specified caller reference.: Seems like the last failed job didn't clean up after itself. Will look into it.

/test e2e-aws-shared-vpc-phz-operator

gcs278 commented 9 months ago

Round 1 - Success: /test e2e-aws-shared-vpc-phz-operator

gcs278 commented 9 months ago

cluster install fail /test e2e-azure-operator

gcs278 commented 9 months ago

https://github.com/openshift/release/pull/43517 merged. testing again. /test e2e-aws-shared-vpc-phz-operator

openshift-merge-robot commented 9 months ago

@gcs278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-operator d04af909927c7c9f47d308ae14e9744b7842c238 link true /test e2e-azure-operator
ci/prow/verify d04af909927c7c9f47d308ae14e9744b7842c238 link true /test verify
ci/prow/e2e-azure-infoblox-operator d04af909927c7c9f47d308ae14e9744b7842c238 link true /test e2e-azure-infoblox-operator
ci/prow/e2e-aws-operator d04af909927c7c9f47d308ae14e9744b7842c238 link true /test e2e-aws-operator
ci/prow/images d04af909927c7c9f47d308ae14e9744b7842c238 link true /test images
ci/prow/e2e-aws-shared-vpc-phz-operator d04af909927c7c9f47d308ae14e9744b7842c238 link true /test e2e-aws-shared-vpc-phz-operator
ci/prow/ci-index-external-dns-operator-bundle d04af909927c7c9f47d308ae14e9744b7842c238 link true /test ci-index-external-dns-operator-bundle

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
gcs278 commented 8 months ago

@alebedev87 I should have addressed everything in your review, but I still need to work confirming that DNS records are deleted.

gcs278 commented 8 months ago

@alebedev87 Addressed latest comments, I also made couple of clean ups: https://github.com/openshift/external-dns-operator/compare/e2330ab8695bfd3d3e0fd803bc95a547772e230a..cd5ab109630a647b08c711a96e5ba12e0e39a699

gcs278 commented 8 months ago

@alebedev87 ready for another round. Fixed your review comments, but also added a make test-e2e-sharedvpc alias for easy run of sharedvpc e2e tests.

Also, I renamed the directory name from e2e_awssharedvpc to e2e_sharedvpc. The package name was already e2e_sharedvpc and I think it's probably better to be platform generic in hopes maybe it will be supported on other platforms.

alebedev87 commented 8 months ago

/lgtm /approve

openshift-ci[bot] commented 8 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/external-dns-operator/blob/main/OWNERS)~~ [alebedev87] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
gcs278 commented 8 months ago

* 2023-10-12T22:10:23Z 3x kubelet: Failed to create pod sandbox: rpc error: code = DeadlineExceeded desc = context deadline exceeded

/test unit /test verify

gcs278 commented 8 months ago

test "verify" failed: pod pending for more than 30m0s: containers have not started in 32m26.844693716s: ci-scheduling-dns-wait, place-entrypoint, sidecar, test:

/test verify /test unit

gcs278 commented 8 months ago

cluster install /test e2e-azure-infoblox-operator

alebedev87 commented 8 months ago

/lgtm

gcs278 commented 8 months ago

Applying the labels myself as:

  1. https://github.com/openshift/external-dns-operator/pull/195 as already ack'ed by everyone.
  2. This is an E2E test, that has no user-facing changes to document or test.

/label docs-approved /label px-approved /label qe-approved

openshift-ci-robot commented 8 months ago

@gcs278: This pull request references NE-1324 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to [this](https://github.com/openshift/external-dns-operator/pull/198): >Add E2E tests for AssumeRole functionality added in https://github.com/openshift/external-dns-operator/pull/195/. It creates a ExternalDNS object with AssumeRole configured inside of a Shared VPC cluster. It then confirms that an example DNS record gets created in a targeted AWS account's hosted zone as well as it queries the DNS record inside the cluster to test end-to-end DNS record functionality. > >This E2E test update is also dependent on https://github.com/openshift/release/pull/42894 which adds a new CI test job `e2e-aws-shared-vpc-phz-operator` to this repo. Without this, this new E2E test will be skipped. > >Dependent on https://github.com/openshift/external-dns-operator/pull/195/ and will need rebase when it merges. > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 8 months ago

@gcs278: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).