search

openshift / external-dns-operator

The ExternalDNS Operator provides simplified ExternalDNS controller management.
Apache License 2.0
29 stars 34 forks source link

OCPBUGS-23562: Add file based OLM catalog and remove SQLite index commands #206

Closed alebedev87 closed 2 months ago

alebedev87 commented 1 year ago

The SQLite based catalog format is deprecated since OCP 4.11. This PR adds the file based catalog which is the latest iteration of the catalog format. Creating file based catalog image doc was loosely followed to create the file based catalog. The commands which use SQLite based catalog are removed.

openshift-ci-robot commented 1 year ago

@alebedev87: This pull request references Jira Issue OCPBUGS-23562, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.0) matches configured target version for branch (4.15.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @lihongan

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/external-dns-operator/pull/206): >The SQLite based catalog format is [deprecated since OCP 4.11](https://docs.openshift.com/container-platform/4.11/operators/admin/olm-managing-custom-catalogs.html#olm-managing-custom-catalogs-sqlite). This PR adds [the file based catalog](https://docs.openshift.com/container-platform/4.14/operators/admin/olm-managing-custom-catalogs.html#olm-managing-custom-catalogs-fb) which is the latest iteration of the catalog format. [Creating file based catalog image doc](https://docs.openshift.com/container-platform/4.14/operators/admin/olm-managing-custom-catalogs.html#olm-creating-fb-catalog-image_olm-managing-custom-catalogs) was loosely followed to create the file based catalog. The commands which use SQLite based catalog are removed. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
candita commented 11 months ago

/assign @rfredette

openshift-bot commented 8 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

alebedev87 commented 8 months ago

/remove-lifecycle stale

openshift-bot commented 5 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

lihongan commented 5 months ago

/remove-lifecycle stale

rfredette commented 2 months ago

/approve /lgtm

thanks!

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfredette

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/external-dns-operator/blob/main/OWNERS)~~ [rfredette] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@alebedev87: Jira Issue OCPBUGS-23562: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-23562 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/external-dns-operator/pull/206): >The SQLite based catalog format is [deprecated since OCP 4.11](https://docs.openshift.com/container-platform/4.11/operators/admin/olm-managing-custom-catalogs.html#olm-managing-custom-catalogs-sqlite). This PR adds [the file based catalog](https://docs.openshift.com/container-platform/4.14/operators/admin/olm-managing-custom-catalogs.html#olm-managing-custom-catalogs-fb) which is the latest iteration of the catalog format. [Creating file based catalog image doc](https://docs.openshift.com/container-platform/4.14/operators/admin/olm-managing-custom-catalogs.html#olm-creating-fb-catalog-image_olm-managing-custom-catalogs) was loosely followed to create the file based catalog. The commands which use SQLite based catalog are removed. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fexternal-dns-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.