search

openshift / external-dns-operator

The ExternalDNS Operator provides simplified ExternalDNS controller management.
Apache License 2.0
22 stars 33 forks source link

OCPBUGS-26538: add infrastructure annotations #213

Closed alebedev87 closed 4 months ago

alebedev87 commented 5 months ago

According to the Red Hat Operator's Best practices the infrastructure annotations are now required. The old "infrastructure-features" annotation is deprecated hence it's removed. The old list of features is mapped to the new set.

openshift-ci-robot commented 5 months ago

@alebedev87: This pull request references Jira Issue OCPBUGS-26538, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/external-dns-operator/pull/213): >According to the Red Hat Operator's [Best practices](https://docs.engineering.redhat.com/display/CFC/Best_Practices) the infrastructure annotations are now required. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fexternal-dns-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
alebedev87 commented 5 months ago

/jira refresh

openshift-ci-robot commented 5 months ago

@alebedev87: This pull request references Jira Issue OCPBUGS-26538, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @lihongan

In response to [this](https://github.com/openshift/external-dns-operator/pull/213#issuecomment-1883143215): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fexternal-dns-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
lihongan commented 5 months ago

did pre-merge test (launch openshift/external-dns-operator#213 gcp)

$ oc -n external-dns-operator get csv external-dns-operator.v1.2.0 -oyaml
<...snip...>
    features.operators.openshift.io/disconnected: "true"
    features.operators.openshift.io/fips-compliant: "false"
    features.operators.openshift.io/proxy-aware: "true"
    features.operators.openshift.io/tls-profiles: "false"
    features.operators.openshift.io/token-auth-aws: "false"
    features.operators.openshift.io/token-auth-azure: "false"
    features.operators.openshift.io/token-auth-gcp: "false"
openshift-ci-robot commented 5 months ago

@alebedev87: This pull request references Jira Issue OCPBUGS-26538, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @lihongan

In response to [this](https://github.com/openshift/external-dns-operator/pull/213): >According to the Red Hat Operator's [Best practices](https://docs.engineering.redhat.com/display/CFC/Best_Practices) the infrastructure annotations are now required. The [old annotation is deprecated](https://github.com/openshift/openshift-docs/pull/69579) hence I removed it. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fexternal-dns-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
candita commented 5 months ago

/assign /assign @Miciah

alebedev87 commented 5 months ago

/retest

alebedev87 commented 5 months ago

/retest

alebedev87 commented 5 months ago

/retest

openshift-ci[bot] commented 5 months ago

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
Miciah commented 4 months ago

/approve /lgtm /hold for @candita's review.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/external-dns-operator/blob/main/OWNERS)~~ [Miciah] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
candita commented 4 months ago

/unhold /lgtm

openshift-ci-robot commented 4 months ago

@alebedev87: Jira Issue OCPBUGS-26538: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-26538 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/external-dns-operator/pull/213): >According to the Red Hat Operator's [Best practices](https://docs.engineering.redhat.com/display/CFC/Best_Practices) the infrastructure annotations are now required. The [old "infrastructure-features" annotation is deprecated](https://github.com/openshift/openshift-docs/pull/69579) hence it's removed. The old list of features is mapped to the new set. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fexternal-dns-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.