search

openshift / external-dns-operator

The ExternalDNS Operator provides simplified ExternalDNS controller management.
Apache License 2.0
29 stars 34 forks source link

OCPBUGS-32058: docs - add example of private dns zone for Azure provider #217

Open alebedev87 opened 7 months ago

alebedev87 commented 7 months ago
openshift-bot commented 7 months ago

@alebedev87: This pull request references Jira Issue OCPBUGS-32058, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/external-dns-operator/pull/217): >Adds an example of the usage of the private dns zone for the Azure provider. Addresses https://github.com/openshift/external-dns-operator/issues/197. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fexternal-dns-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
alebedev87 commented 7 months ago

/jira refresh

openshift-bot commented 7 months ago

@alebedev87: This pull request references Jira Issue OCPBUGS-32058, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @melvinjoseph86

In response to [this](https://github.com/openshift/external-dns-operator/pull/217#issuecomment-2049417585): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fexternal-dns-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 7 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from alebedev87. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/external-dns-operator/blob/main/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 7 months ago

@alebedev87: This pull request references Jira Issue OCPBUGS-32058, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @melvinjoseph86

In response to [this](https://github.com/openshift/external-dns-operator/pull/217): >Adds an example of the usage of the private dns zone for the Azure provider. Addresses https://github.com/openshift/external-dns-operator/issues/197. >Also, a mistake was found in `az network dns record-set list` command, the correct syntax is`az network dns record-set a list`. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fexternal-dns-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 7 months ago

@alebedev87: This pull request references Jira Issue OCPBUGS-32058, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @melvinjoseph86

In response to [this](https://github.com/openshift/external-dns-operator/pull/217): >- Adds an example of the usage of the private dns zone for the Azure provider >- Addresses https://github.com/openshift/external-dns-operator/issues/197 >- Mistake was found in `az network dns record-set list` command, the correct syntax is`az network dns record-set a list` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fexternal-dns-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
melvinjoseph86 commented 7 months ago 
melvinjoseph@mjoseph-mac Downloads % oc get clusterversion
NAME      VERSION                                                   AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.16.0-0.ci.test-2024-04-17-071445-ci-ln-vgviiqb-latest   True        False         34m     Cluster version is 4.16.0-0.ci.test-2024-04-17-071445-ci-ln-vgviiqb-latest
melvinjoseph@mjoseph-mac Downloads % 
melvinjoseph@mjoseph-mac Downloads % 
melvinjoseph@mjoseph-mac Downloads % CLIENT_ID=$(oc get secrets azure-credentials  -n kube-system  --template={{.data.azure_client_id}} | base64 -d)
CLIENT_SECRET=$(oc get secrets azure-credentials  -n kube-system  --template={{.data.azure_client_secret}} | base64 -d)
RESOURCE_GROUP=$(oc get secrets azure-credentials  -n kube-system  --template={{.data.azure_resourcegroup}} | base64 -d)
SUBSCRIPTION_ID=$(oc get secrets azure-credentials  -n kube-system  --template={{.data.azure_subscription_id}} | base64 -d)
TENANT_ID=$(oc get secrets azure-credentials  -n kube-system  --template={{.data.azure_tenant_id}} | base64 -d)

melvinjoseph@mjoseph-mac Downloads % 
melvinjoseph@mjoseph-mac Downloads % az login --service-principal -u "${CLIENT_ID}" -p "${CLIENT_SECRET}" --tenant "${TENANT_ID}"
[
  {
    "cloudName": "AzureCloud",
    "homeTenantId": "6047c7e9-b2ad-488d-a54e-dc3f6be6a7ee",
    "id": "d38f1e38-4bed-438e-b227-833f997adf6a",
    "isDefault": true,
    "managedByTenants": [],
    "name": "OpenShift CI",
    "state": "Enabled",
    "tenantId": "6047c7e9-b2ad-488d-a54e-dc3f6be6a7ee",
    "user": {
      "name": "4f03bcab-7b63-4617-9641-0e2eeb9cc5eb",
      "type": "servicePrincipal"
    }
  },
  {
    "cloudName": "AzureCloud",
    "homeTenantId": "6047c7e9-b2ad-488d-a54e-dc3f6be6a7ee",
    "id": "72e3a972-58b0-4afc-bd4f-da89b39ccebd",
    "isDefault": false,
    "managedByTenants": [],
    "name": "OpenShift CI 2",
    "state": "Enabled",
    "tenantId": "6047c7e9-b2ad-488d-a54e-dc3f6be6a7ee",
    "user": {
      "name": "4f03bcab-7b63-4617-9641-0e2eeb9cc5eb",
      "type": "servicePrincipal"
    }
  }
]melvinjoseph@mjoseph-mac Downloads % ZONE_NAME=$(az network private-dns zone list -g "${RESOURCE_GROUP}" -o tsv --query '[].name')
melvinjoseph@mjoseph-mac Downloads % echo $ZONE_NAME
ci-ln-vgviiqb-1d09d.ci.azure.devcluster.openshift.com
melvinjoseph@mjoseph-mac Downloads % cat <<EOF | oc create -f -
apiVersion: externaldns.olm.openshift.io/v1beta1
kind: ExternalDNS
metadata:
  name: sample-azure-private
spec:
  zones:
  - "/subscriptions/${SUBSCRIPTION_ID}/resourceGroups/${RESOURCE_GROUP}/providers/Microsoft.Network/privateDnsZones/${ZONE_NAME}"
  provider:
    type: Azure
  source:
    type: OpenShiftRoute
    openshiftRouteOptions:
      routerName: default
EOF
externaldns.externaldns.olm.openshift.io/sample-azure-private created

melvinjoseph@mjoseph-mac Downloads % az network private-dns record-set list -g "${RESOURCE_GROUP}" -z "${ZONE_NAME}" | grep console
    "fqdn": "console-openshift-console.apps.ci-ln-vgviiqb-1d09d.ci.azure.devcluster.openshift.com.",
    "id": "/subscriptions/d38f1e38-4bed-438e-b227-833f997adf6a/resourceGroups/ci-ln-vgviiqb-1d09d-mzsj6-rg/providers/Microsoft.Network/privateDnsZones/ci-ln-vgviiqb-1d09d.ci.azure.devcluster.openshift.com/CNAME/console-openshift-console.apps",
    "name": "console-openshift-console.apps",
    "fqdn": "downloads-openshift-console.apps.ci-ln-vgviiqb-1d09d.ci.azure.devcluster.openshift.com.",
    "id": "/subscriptions/d38f1e38-4bed-438e-b227-833f997adf6a/resourceGroups/ci-ln-vgviiqb-1d09d-mzsj6-rg/providers/Microsoft.Network/privateDnsZones/ci-ln-vgviiqb-1d09d.ci.azure.devcluster.openshift.com/CNAME/downloads-openshift-console.apps",
    "name": "downloads-openshift-console.apps",
    "fqdn": "external-dns-cname-console-openshift-console.apps.ci-ln-vgviiqb-1d09d.ci.azure.devcluster.openshift.com.",
    "id": "/subscriptions/d38f1e38-4bed-438e-b227-833f997adf6a/resourceGroups/ci-ln-vgviiqb-1d09d-mzsj6-rg/providers/Microsoft.Network/privateDnsZones/ci-ln-vgviiqb-1d09d.ci.azure.devcluster.openshift.com/TXT/external-dns-cname-console-openshift-console.apps",
    "name": "external-dns-cname-console-openshift-console.apps",
          "\"heritage=external-dns,external-dns/owner=external-dns-sample-azure-private,external-dns/resource=route/openshift-console/console\""
    "fqdn": "external-dns-cname-downloads-openshift-console.apps.ci-ln-vgviiqb-1d09d.ci.azure.devcluster.openshift.com.",
    "id": "/subscriptions/d38f1e38-4bed-438e-b227-833f997adf6a/resourceGroups/ci-ln-vgviiqb-1d09d-mzsj6-rg/providers/Microsoft.Network/privateDnsZones/ci-ln-vgviiqb-1d09d.ci.azure.devcluster.openshift.com/TXT/external-dns-cname-downloads-openshift-console.apps",
    "name": "external-dns-cname-downloads-openshift-console.apps",
          "\"heritage=external-dns,external-dns/owner=external-dns-sample-azure-private,external-dns/resource=route/openshift-console/downloads\""
    "fqdn": "external-dns-console-openshift-console.apps.ci-ln-vgviiqb-1d09d.ci.azure.devcluster.openshift.com.",
    "id": "/subscriptions/d38f1e38-4bed-438e-b227-833f997adf6a/resourceGroups/ci-ln-vgviiqb-1d09d-mzsj6-rg/providers/Microsoft.Network/privateDnsZones/ci-ln-vgviiqb-1d09d.ci.azure.devcluster.openshift.com/TXT/external-dns-console-openshift-console.apps",
    "name": "external-dns-console-openshift-console.apps",
          "\"heritage=external-dns,external-dns/owner=external-dns-sample-azure-private,external-dns/resource=route/openshift-console/console\""
    "fqdn": "external-dns-downloads-openshift-console.apps.ci-ln-vgviiqb-1d09d.ci.azure.devcluster.openshift.com.",
    "id": "/subscriptions/d38f1e38-4bed-438e-b227-833f997adf6a/resourceGroups/ci-ln-vgviiqb-1d09d-mzsj6-rg/providers/Microsoft.Network/privateDnsZones/ci-ln-vgviiqb-1d09d.ci.azure.devcluster.openshift.com/TXT/external-dns-downloads-openshift-console.apps",
    "name": "external-dns-downloads-openshift-console.apps",
          "\"heritage=external-dns,external-dns/owner=external-dns-sample-azure-private,external-dns/resource=route/openshift-console/downloads\""
melvinjoseph@mjoseph-mac Downloads %

Hence marking as verified

melvinjoseph86 commented 7 months ago

/label qe-approved

openshift-ci-robot commented 7 months ago

@alebedev87: This pull request references Jira Issue OCPBUGS-32058, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @melvinjoseph86

In response to [this](https://github.com/openshift/external-dns-operator/pull/217): >- Adds an example of the usage of the private dns zone for the Azure provider >- Addresses https://github.com/openshift/external-dns-operator/issues/197 >- Mistake was found in `az network dns record-set list` command, the correct syntax is`az network dns record-set a list` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fexternal-dns-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
candita commented 7 months ago

/assign

openshift-bot commented 4 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

candita commented 4 months ago

/lifecycle frozen

openshift-ci[bot] commented 4 months ago

@candita: The lifecycle/frozen label cannot be applied to Pull Requests.

In response to [this](https://github.com/openshift/external-dns-operator/pull/217#issuecomment-2233756139): >/lifecycle frozen Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
candita commented 4 months ago

@alebedev87 in the description you mention a mistake that was found, but that command still exists with the old syntax:

Mistake was found in az network dns record-set list command, the correct syntax isaz network dns record-set a list

Otherwise, just some minor clarifications needed.

alebedev87 commented 3 months ago

/remove-lifecycle stale

openshift-ci-robot commented 2 months ago

@alebedev87: This pull request references Jira Issue OCPBUGS-32058, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Retaining the jira/valid-bug label as it was manually added.

In response to [this](https://github.com/openshift/external-dns-operator/pull/217): >- Adds an example of the usage of the private dns zone for the Azure provider >- Addresses https://github.com/openshift/external-dns-operator/issues/197 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fexternal-dns-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
alebedev87 commented 2 months ago

@candita:

in the description you mention a mistake that was found, but that command still exists with the old syntax:

Mistake was found in az network dns record-set list command, the correct syntax isaz network dns record-set a list

As a matter of fact az network dns record-set list is a valid command which lists DNS records of all types. Initially I thought the doc wanted to list only A records (az network dns record-set a list) but then I realized that the intent was to list TXT records too. So, I left the command the way it was and removed this line from the PR description.

openshift-ci[bot] commented 2 months ago

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).