search

openshift / file-integrity-operator

Operator providing OpenShift cluster node file integrity checking
Apache License 2.0
31 stars 27 forks source link

tests: Set logger to an empty sink in tests #421

Closed rhmdnd closed 1 year ago

rhmdnd commented 1 year ago

This is pretty much https://github.com/fluxcd/flux2/commit/aa65589391db2433691d8cebde5c77c090cae3a9 reused.

The new controller-runtime version requires that the logger is set or else there's a stack trace printed. Since even the original code doesn't use any logger for tests, let's just use null logger with the new version as well.

rhmdnd commented 1 year ago

This is https://github.com/openshift/file-integrity-operator/pull/389 but rebased on master to get a clean test run.

rhmdnd commented 1 year ago

/test all

rhmdnd commented 1 year ago

/test all

Failures are due to issues with CI image registries.

rhmdnd commented 1 year ago

/test e2e-bundle-aws

Failed to get a cluster

rhmdnd commented 1 year ago

/test e2e-bundle-aws

Image signature issue.

openshift-ci-robot commented 1 year ago

/retest-required

Remaining retests: 0 against base HEAD 97981b443c6f2c3cc4c7e0b4c95e87634a6f0d50 and 2 for PR HEAD 176b29b7e7aeb47e7c05185a72e22cc72fa0270c in total

rhmdnd commented 1 year ago

/retest

rhmdnd commented 1 year ago

Rebased to pick up CI fixes that landed in master.

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056, yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/file-integrity-operator/blob/master/OWNERS)~~ [Vincent056,rhmdnd,yuumasato] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 year ago

@rhmdnd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).