OCPBUGS-14947: Fix hostmount propagation

Vincent056 commented 1 year ago

This PR fixes issues on CSI driver relying on multipath, we need to set MountPropagation to HostToContainer to address this issue.

OCPBUGS-14947

openshift-ci-robot commented 1 year ago

@Vincent056: This pull request references Jira Issue OCPBUGS-14947, which is invalid:

expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/file-integrity-operator/pull/424): >This PR fixes issues on CSI driver relying on multipath, we need to set MountPropagation to HostToContainer to address this issue. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

openshift-ci-robot commented 1 year ago

@Vincent056: This pull request references Jira Issue OCPBUGS-14947, which is invalid:

expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/file-integrity-operator/pull/424): >This PR fixes issues on CSI driver relying on multipath, we need to set MountPropagation to HostToContainer to address this issue. > >[OCPBUGS-14947](https://issues.redhat.com/browse/OCPBUGS-14947) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

openshift-ci[bot] commented 1 year ago

@Vincent056: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/file-integrity-operator/blob/master/OWNERS)~~ [Vincent056,rhmdnd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

xiaojiey commented 1 year ago

Verification pass with 4.14.0-0.nightly-2023-08-10-072041 + Code in the PR: Per https://access.redhat.com/solutions/7017081, verified daemon container of aide pods have now the HostToContainer mount propagation.

$ oc apply -f -<<EOF
apiVersion: fileintegrity.openshift.io/v1alpha1
kind: FileIntegrity
metadata:
  name: example-fileintegrity
spec:
  config:
    gracePeriod: 300
    maxBackups: 5
  debug: true
EOF
fileintegrity.fileintegrity.openshift.io/example-fileintegrity created
$ oc get pod
NAME                                       READY   STATUS    RESTARTS      AGE
aide-example-fileintegrity-6n45r           1/1     Running   0             3m30s
aide-example-fileintegrity-8r7qt           1/1     Running   0             3m30s
aide-example-fileintegrity-b92d6           1/1     Running   0             3m30s
aide-example-fileintegrity-jj598           1/1     Running   0             3m30s
aide-example-fileintegrity-ntkmf           1/1     Running   0             3m30s
aide-example-fileintegrity-zqlgc           1/1     Running   0             3m30s
file-integrity-operator-6b67d89b67-nk6dr   1/1     Running   1 (91m ago)   91m
$ oc get pod -l file-integrity.openshift.io/pod= '-o=jsonpath={.items[*].spec.containers[?(@.name=="daemon")].volumeMounts[0]}' | jq -r
{
  "mountPath": "/hostroot",
  "mountPropagation": "HostToContainer",
  "name": "hostroot"
}
{
  "mountPath": "/hostroot",
  "mountPropagation": "HostToContainer",
  "name": "hostroot"
}
{
  "mountPath": "/hostroot",
  "mountPropagation": "HostToContainer",
  "name": "hostroot"
}
{
  "mountPath": "/hostroot",
  "mountPropagation": "HostToContainer",
  "name": "hostroot"
}
{
  "mountPath": "/hostroot",
  "mountPropagation": "HostToContainer",
  "name": "hostroot"
}
{
  "mountPath": "/hostroot",
  "mountPropagation": "HostToContainer",
  "name": "hostroot"
}

xiaojiey commented 1 year ago

/label qe-approved

Vincent056 commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@Vincent056: This pull request references Jira Issue OCPBUGS-14947, which is invalid:

expected the bug to target the "4.14.0" version, but no target version was set
expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/file-integrity-operator/pull/424#issuecomment-1674939075): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

xiaojiey commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@xiaojiey: This pull request references Jira Issue OCPBUGS-14947, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/file-integrity-operator/pull/424#issuecomment-1676593080): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

xiaojiey commented 1 year ago

/jira refresh

openshift-ci-robot commented 1 year ago

@xiaojiey: This pull request references Jira Issue OCPBUGS-14947, which is valid.

3 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.14.0) matches configured target version for branch (4.14.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

In response to [this](https://github.com/openshift/file-integrity-operator/pull/424#issuecomment-1676593640): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

openshift-ci-robot commented 1 year ago

@Vincent056: Jira Issue OCPBUGS-14947: All pull requests linked via external trackers have merged:

openshift/file-integrity-operator#424

Jira Issue OCPBUGS-14947 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/file-integrity-operator/pull/424): >This PR fixes issues on CSI driver relying on multipath, we need to set MountPropagation to HostToContainer to address this issue. > >[OCPBUGS-14947](https://issues.redhat.com/browse/OCPBUGS-14947) Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

openshift / file-integrity-operator

OCPBUGS-14947: Fix hostmount propagation #424