openshift / file-integrity-operator

Operator providing OpenShift cluster node file integrity checking
Apache License 2.0
31 stars 27 forks source link

Exclude MCO registry secret from integrity checks #541

Closed rhmdnd closed 4 months ago

rhmdnd commented 4 months ago

We're noticing some issues in CI where tests time out because node never reach their desired state. We've also noticed MCO making changes to a file that was previously monitored, causing failures we weren't expecting.

This commit attempts to fix the issue by excluding the MCO file in question so it stops raising false negative results in the e2e suite.

openshift-ci[bot] commented 4 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/file-integrity-operator/blob/master/OWNERS)~~ [rhmdnd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
Vincent056 commented 4 months ago

/lgtm /retest

Vincent056 commented 4 months ago

We're noticing some issues in CI where tests time out because node never reach their desired state. We've also noticed MCO making changes to a file that was previously monitored, causing failures we weren't expecting.

This commit attempts to fix the issue by excluding the MCO file in question so it stops raising false negative results in the e2e suite.

https://redhat-internal.slack.com/archives/C02CZNQHGN8/p1720621801639479 we should be good to exclude that

openshift-ci[bot] commented 4 months ago

@rhmdnd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).