search

openshift / file-integrity-operator

Operator providing OpenShift cluster node file integrity checking
Apache License 2.0
31 stars 27 forks source link

AIDE 0.18 e2e #550

Closed Vincent056 closed 1 month ago

Vincent056 commented 2 months ago

This PR adds the dockerfile that builds operator image with the AIDE 0.18, also replacing 0.16 config file with the 0.18 conf file using the migration logic depends on value of AIDE_VERSION. We will use 0.16 as default value if not set. This is for us to have CI to test AIDE config.

We will need to merge this one and test on https://github.com/openshift/release/pull/54911

Vincent056 commented 1 month ago

/retest

rhmdnd commented 1 month ago

Ok - looks good. I only have one minor suggestion on the new e2e suite for AIDE 0.18.0 to make it optional and then we can start exercising it against this PR.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/file-integrity-operator/blob/master/OWNERS)~~ [Vincent056,rhmdnd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rhmdnd commented 1 month ago

No docs or px needed yet since this is laying down the test plumbing. No functional changes.

/px-approved /docs-approved

openshift-ci[bot] commented 1 month ago

@Vincent056: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).