search

openshift / file-integrity-operator

Operator providing OpenShift cluster node file integrity checking
Apache License 2.0
31 stars 27 forks source link

Skip test that require machine configs on ROSA HCP #554

Open rhmdnd opened 1 month ago

rhmdnd commented 1 month ago

We recently added support for running tests on ROSA HCP, which doesn't support some objects like Machine Configs:

https://github.com/openshift/release/pull/53502

Because of this, the TestFileIntegrityAcceptsExpectedChange test is failing because it expects to create a Machine Config as a dependency for the test.

This commit updates the test to check if we're running on ROSA HCP, and if so, skip the test.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/file-integrity-operator/blob/master/OWNERS)~~ [rhmdnd] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

@rhmdnd: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-rosa 8b3bcf74cd7287e7d56f77a63530321cac89435b link false /test e2e-rosa
ci/prow/e2e-aws 8b3bcf74cd7287e7d56f77a63530321cac89435b link true /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).