search

openshift / geard

geard is no longer maintained - see OpenShift 3 and Kubernetes
Other
405 stars 80 forks source link

Fix deletion of STI temp dir on exit #176

Closed ncdc closed 10 years ago

ncdc commented 10 years ago

Code cleanup/refactoring.

Change call from os.Remove to os.RemoveAll to remove the temp dir and its contents.

Only chown /tmp/artifacts.

Remove the chgrp portion of the chown calls as it shouldn't be necessary and it keeps the user running sti from being able to delete the temp dir.

Change /tmp/artifacts from 755 to 775 so it's group writable, meaning it should be able to be deleted by the host user.

Fix issue where the build would fail when trying to determine the default scripts URL if the image didn't already exist locally.

Fixes #164

ncdc commented 10 years ago

[test]

openshift-bot commented 10 years ago

Origin Test Results: SUCCESS (https://50.17.198.52/jenkins/job/test_pull_requests_geard/85/)

mfojtik commented 10 years ago

:+1: LGTM

ncdc commented 10 years ago

[test]

ncdc commented 10 years ago

[test]

ncdc commented 10 years ago

[test]

ncdc commented 10 years ago

[merge]

openshift-bot commented 10 years ago

Origin Merge Results: SUCCESS (https://50.17.198.52/jenkins/job/merge_pull_requests_geard/7/) (Image: devenv-fedora_60)

openshift-bot commented 10 years ago

Evaluated for origin up to 8351abc837029cbccd5071479a262a2f95c46075