search

openshift / geard

geard is no longer maintained - see OpenShift 3 and Kubernetes
Other
405 stars 80 forks source link

[WIP] Build artifacts and run some tests in parallel #232

Closed VojtechVitek closed 10 years ago

openshift-bot commented 10 years ago

Origin Test Results: FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_requests_geard/160/)

VojtechVitek commented 10 years ago

[test]

VojtechVitek commented 10 years ago

@smarterclayton @mfojtik this PR forces the following steps to be run in parallel:

What do you think? Is there anything else that we could parallelize?

smarterclayton commented 10 years ago

How much faster is this? The slowest check by far in the build is the go get dependency check (when there are no changes) - i'm surprised this even makes much of a difference.

The actual build of both switchns and gear-auth-keys-command should be extremely fast because everything else is already built.

smarterclayton commented 10 years ago

Did you try 

go install  ./cmd/...

which should install all 4 (on the platforms they support)?

VojtechVitek commented 10 years ago

It's several seconds faster, not that much.. But you can feel the difference when running ./contrib/build -l on localhost (while developing).

My first intention was to run all the tests in parallel, which would make it significantly faster.. but I didn't realized that some of the tests are dependent on each other (integration steps need images).

I didn't try go install ./cmd/... .. are you saying it's building everything in parallel as well?

openshift-bot commented 10 years ago

Evaluated for origin up to 7dbf76068b5015ac4276c82b9c3490fff02ad09d

smarterclayton commented 10 years ago

Yeah, go install ./cmd/... should build everything in parallel and benefit from only needing to check certain things once. It should be the fastest way to build multiple things.