search

openshift / geard

geard is no longer maintained - see OpenShift 3 and Kubernetes
Other
405 stars 80 forks source link

Bug 1118597 - Do not exit if the extra STI script download failed #241

Closed mfojtik closed 9 years ago

mfojtik commented 10 years ago

If we fail to download some script (like when users are overriding the default STI_SCRIPTS_URL with --scripts), then we should not fail the build when we have all required scripts already downloaded. It might be useful to just tell users that "some" of the scripts failed to download, which means it build will probably not pick up the script they supplied by --scripts.

smarterclayton commented 10 years ago

So the user requests scripts, but then we can't get them, so we continue anyway? As described, it seems like failing is the correct behavior - if I tell you to do something specific, and that action fails, if you ignore that the generated output may not match what I requested.

Or am I misunderstanding the point of the fix?

bparees commented 10 years ago

@mfojtik hey can you complete this merge? then we can close https://bugzilla.redhat.com/show_bug.cgi?id=1118597 and we'll probably want the fix in as we use sti w/ k8s.