openshift / hive

API driven OpenShift cluster provisioning and management
Apache License 2.0
249 stars 237 forks source link

[mce-2.3] MachinePools/OpenStack: Fix nil pointer exception #2411

Closed openshift-cherrypick-robot closed 2 months ago

openshift-cherrypick-robot commented 2 months ago

This is an automated cherry-pick of #2410

/assign 2uasimojo

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.80%. Comparing base (1009029) to head (a71f5c8).

Files Patch % Lines
pkg/controller/machinepool/openstackactuator.go 0.00% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/hive/pull/2411/graphs/tree.svg?width=650&height=150&src=pr&token=2md6QUue4c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/hive/pull/2411?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## mce-2.3 #2411 +/- ## =========================================== - Coverage 57.80% 57.80% -0.01% =========================================== Files 186 186 Lines 25333 25335 +2 =========================================== Hits 14645 14645 - Misses 9437 9439 +2 Partials 1251 1251 ``` | [Files](https://app.codecov.io/gh/openshift/hive/pull/2411?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/controller/machinepool/openstackactuator.go](https://app.codecov.io/gh/openshift/hive/pull/2411?src=pr&el=tree&filepath=pkg%2Fcontroller%2Fmachinepool%2Fopenstackactuator.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2NvbnRyb2xsZXIvbWFjaGluZXBvb2wvb3BlbnN0YWNrYWN0dWF0b3IuZ28=) | `19.09% <0.00%> (-0.36%)` | :arrow_down: |
2uasimojo commented 2 months ago

/override ci/prow/security

azidentity addressed elsewhere.

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hive/blob/mce-2.3/OWNERS)~~ [2uasimojo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security

In response to [this](https://github.com/openshift/hive/pull/2411#issuecomment-2278198217): >/override ci/prow/security > >azidentity addressed elsewhere. > >/lgtm Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security a71f5c80f433207c0ef3dd74de8a72a6aa5def83 link true /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).