Closed 2uasimojo closed 1 month ago
/assign @lleshchi
@2uasimojo: all tests passed!
Full PR test history. Your PR dashboard.
Attention: Patch coverage is 0%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 46.27%. Comparing base (
bbda5ef
) to head (7909fe7
).
Files | Patch % | Lines |
---|---|---|
...g/controller/machinepool/machinepool_controller.go | 0.00% | 4 Missing :warning: |
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: 2uasimojo, lleshchi
The full list of commands accepted by this bot can be found here.
The pull request process is described here
We are having lots of problems with MachinePool scaling since we introduced failure domain matching as the way to tell whether a generated MachineSet needs to be created, updated, or deleted on the spoke. This commit adds logging that prints the contents of the generated and remote failure domains when a mismatch is detected. It should help with FFDC in the field.