openshift / hive

API driven OpenShift cluster provisioning and management
Apache License 2.0
247 stars 238 forks source link

MachinePool failure domain logging #2412

Closed 2uasimojo closed 1 month ago

2uasimojo commented 1 month ago

We are having lots of problems with MachinePool scaling since we introduced failure domain matching as the way to tell whether a generated MachineSet needs to be created, updated, or deleted on the spoke. This commit adds logging that prints the contents of the generated and remote failure domains when a mismatch is detected. It should help with FFDC in the field.

2uasimojo commented 1 month ago

/assign @lleshchi

openshift-ci[bot] commented 1 month ago

@2uasimojo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 46.27%. Comparing base (bbda5ef) to head (7909fe7).

Files Patch % Lines
...g/controller/machinepool/machinepool_controller.go 0.00% 4 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/hive/pull/2412/graphs/tree.svg?width=650&height=150&src=pr&token=2md6QUue4c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/hive/pull/2412?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #2412 +/- ## ========================================== - Coverage 46.28% 46.27% -0.01% ========================================== Files 279 279 Lines 32759 32762 +3 ========================================== Hits 15162 15162 - Misses 16324 16327 +3 Partials 1273 1273 ``` | [Files](https://app.codecov.io/gh/openshift/hive/pull/2412?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [...g/controller/machinepool/machinepool\_controller.go](https://app.codecov.io/gh/openshift/hive/pull/2412?src=pr&el=tree&filepath=pkg%2Fcontroller%2Fmachinepool%2Fmachinepool_controller.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2NvbnRyb2xsZXIvbWFjaGluZXBvb2wvbWFjaGluZXBvb2xfY29udHJvbGxlci5nbw==) | `53.48% <0.00%> (-0.20%)` | :arrow_down: |
lleshchi commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, lleshchi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hive/blob/master/OWNERS)~~ [2uasimojo,lleshchi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment