Closed 2uasimojo closed 3 weeks ago
/assign @suhanime
@2uasimojo: all tests passed!
Full PR test history. Your PR dashboard.
Attention: Patch coverage is 0%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 46.28%. Comparing base (
b3eca52
) to head (ef18c9b
). Report is 2 commits behind head on master.
Files | Patch % | Lines |
---|---|---|
pkg/operator/hive/sharded_controllers.go | 0.00% | 5 Missing :warning: |
...g/controller/machinepool/machinepool_controller.go | 0.00% | 1 Missing :warning: |
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: 2uasimojo, suhanime
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Previous work (#2310 / 4117577) added a knob to control the poll interval for the MachinePool controller.
Then a subsequent effort (#2341 / 35ce9c6) split the MachinePool controller into its own StatefulSet.
But the latter forgot to carry the poll interval plumbing into the sharded version of the controller.
Fix.
HIVE-2536