openshift / hive

API driven OpenShift cluster provisioning and management
Apache License 2.0
247 stars 238 forks source link

Fix MachinePool poll interval for sharded controller #2421

Closed 2uasimojo closed 3 weeks ago

2uasimojo commented 4 weeks ago

Previous work (#2310 / 4117577) added a knob to control the poll interval for the MachinePool controller.

Then a subsequent effort (#2341 / 35ce9c6) split the MachinePool controller into its own StatefulSet.

But the latter forgot to carry the poll interval plumbing into the sharded version of the controller.

Fix.

HIVE-2536

2uasimojo commented 4 weeks ago

/assign @suhanime

openshift-ci[bot] commented 4 weeks ago

@2uasimojo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
codecov[bot] commented 4 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 46.28%. Comparing base (b3eca52) to head (ef18c9b). Report is 2 commits behind head on master.

Files Patch % Lines
pkg/operator/hive/sharded_controllers.go 0.00% 5 Missing :warning:
...g/controller/machinepool/machinepool_controller.go 0.00% 1 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/hive/pull/2421/graphs/tree.svg?width=650&height=150&src=pr&token=2md6QUue4c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/hive/pull/2421?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #2421 +/- ## ========================================== - Coverage 46.28% 46.28% -0.01% ========================================== Files 279 279 Lines 32767 32772 +5 ========================================== Hits 15167 15167 - Misses 16327 16332 +5 Partials 1273 1273 ``` | [Files](https://app.codecov.io/gh/openshift/hive/pull/2421?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/operator/hive/hive.go](https://app.codecov.io/gh/openshift/hive/pull/2421?src=pr&el=tree&filepath=pkg%2Foperator%2Fhive%2Fhive.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL29wZXJhdG9yL2hpdmUvaGl2ZS5nbw==) | `0.00% <ø> (ø)` | | | [...g/controller/machinepool/machinepool\_controller.go](https://app.codecov.io/gh/openshift/hive/pull/2421?src=pr&el=tree&filepath=pkg%2Fcontroller%2Fmachinepool%2Fmachinepool_controller.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2NvbnRyb2xsZXIvbWFjaGluZXBvb2wvbWFjaGluZXBvb2xfY29udHJvbGxlci5nbw==) | `53.48% <0.00%> (ø)` | | | [pkg/operator/hive/sharded\_controllers.go](https://app.codecov.io/gh/openshift/hive/pull/2421?src=pr&el=tree&filepath=pkg%2Foperator%2Fhive%2Fsharded_controllers.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL29wZXJhdG9yL2hpdmUvc2hhcmRlZF9jb250cm9sbGVycy5nbw==) | `0.00% <0.00%> (ø)` | |
suhanime commented 3 weeks ago

/lgtm

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, suhanime

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hive/blob/master/OWNERS)~~ [2uasimojo,suhanime] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment