openshift / hive

API driven OpenShift cluster provisioning and management
Apache License 2.0
249 stars 237 forks source link

[mce-2.6] Remove existing Secret files in (deprovision) Pod #2426

Closed openshift-cherrypick-robot closed 2 months ago

openshift-cherrypick-robot commented 2 months ago

This is an automated cherry-pick of #2425

/assign 2uasimojo

/cherrypick mce-2.5 mce-2.4 mce-2.3

HIVE-2604

2uasimojo commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hive/blob/mce-2.6/OWNERS)~~ [2uasimojo] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.60%. Comparing base (67495e3) to head (7c42741). Report is 2 commits behind head on mce-2.6.

Files Patch % Lines
contrib/pkg/utils/generic.go 0.00% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/hive/pull/2426/graphs/tree.svg?width=650&height=150&src=pr&token=2md6QUue4c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/hive/pull/2426?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## mce-2.6 #2426 +/- ## =========================================== - Coverage 58.60% 58.60% -0.01% =========================================== Files 181 181 Lines 25822 25824 +2 =========================================== Hits 15134 15134 - Misses 9415 9417 +2 Partials 1273 1273 ``` | [Files](https://app.codecov.io/gh/openshift/hive/pull/2426?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [contrib/pkg/utils/generic.go](https://app.codecov.io/gh/openshift/hive/pull/2426?src=pr&el=tree&filepath=contrib%2Fpkg%2Futils%2Fgeneric.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-Y29udHJpYi9wa2cvdXRpbHMvZ2VuZXJpYy5nbw==) | `9.75% <0.00%> (-0.17%)` | :arrow_down: |
openshift-cherrypick-robot commented 2 months ago

@openshift-cherrypick-robot: new pull request created: #2427

In response to [this](): >This is an automated cherry-pick of #2425 > >/assign 2uasimojo > >/cherrypick mce-2.5 mce-2.4 mce-2.3 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.