search

openshift / hive

API driven OpenShift cluster provisioning and management
Apache License 2.0
247 stars 238 forks source link

Add e2e support for vsphere #2437

Closed lleshchi closed 1 week ago

lleshchi commented 2 weeks ago

This is the hive side of HIVE-2270, which must be merged prior to its corresponding PR in the release repo. Adds support for vsphere platform in e2e tests, utilizing necessary environment variables gathered from the ci-operator workflow.

lleshchi commented 2 weeks ago

/assign @2uasimojo

2uasimojo commented 1 week ago

/test e2e /lgtm /override "Red Hat Konflux / hive-operator-enterprise-contract / hive"

openshift-ci[bot] commented 1 week ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, lleshchi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hive/blob/master/OWNERS)~~ [2uasimojo,lleshchi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 week ago

@2uasimojo: Overrode contexts on behalf of 2uasimojo: Red Hat Konflux / hive-operator-enterprise-contract / hive

In response to [this](https://github.com/openshift/hive/pull/2437#issuecomment-2326993479): >/test e2e >/lgtm >/override "Red Hat Konflux / hive-operator-enterprise-contract / hive" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 week ago

@lleshchi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
lleshchi commented 1 week ago

/retest

lleshchi commented 1 week ago

@2uasimojo ready for review

2uasimojo commented 1 week ago

@2uasimojo ready for review

You have my lgtm -- unhold at will.

lleshchi commented 1 week ago

/hold cancel /override "Red Hat Konflux / hive-operator-enterprise-contract / hive"

openshift-ci[bot] commented 1 week ago

@lleshchi: /override requires failed status contexts, check run or a prowjob name to operate on. The following unknown contexts/checkruns were given:

Only the following failed contexts/checkruns were expected:

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to [this](https://github.com/openshift/hive/pull/2437#issuecomment-2329421880): >/hold cancel >/override "Red Hat Konflux / hive-operator-enterprise-contract / hive" > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.