Revendor installer: OpenStack >=1 MachineSet

[2uasimojo]

We got unlucky when we revendored installer and picked up OCPBUGS-17064, which causes the MachineSets generator to produce zero MachineSets when the input specifies zero Replicas, as it does when we're autoscaling.

Revendor to the (current) tip of the 4.14 branch to pick up the fix.

HIVE-2590

Manual redo of #2436

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.63%. Comparing base (cdfcf06) to head (791fd3c). Report is 2 commits behind head on mce-2.4.

Additional details and impacted files

[](https://app.codecov.io/gh/openshift/hive/pull/2438?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## mce-2.4 #2438 +/- ## ======================================== Coverage 57.63% 57.63% ======================================== Files 186 186 Lines 25842 25843 +1 ======================================== + Hits 14893 14894 +1 Misses 9703 9703 Partials 1246 1246 ``` | [Files with missing lines](https://app.codecov.io/gh/openshift/hive/pull/2438?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/controller/machinepool/awsactuator.go](https://app.codecov.io/gh/openshift/hive/pull/2438?src=pr&el=tree&filepath=pkg%2Fcontroller%2Fmachinepool%2Fawsactuator.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2NvbnRyb2xsZXIvbWFjaGluZXBvb2wvYXdzYWN0dWF0b3IuZ28=) | `78.43% <100.00%> (ø)` | | | [...g/controller/machinepool/machinepool\_controller.go](https://app.codecov.io/gh/openshift/hive/pull/2438?src=pr&el=tree&filepath=pkg%2Fcontroller%2Fmachinepool%2Fmachinepool_controller.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2NvbnRyb2xsZXIvbWFjaGluZXBvb2wvbWFjaGluZXBvb2xfY29udHJvbGxlci5nbw==) | `53.78% <100.00%> (+0.05%)` | :arrow_up: |

[2uasimojo]

/override ci/prow/security

2387 backport

[openshift-ci[bot]]

@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security

In response to [this](https://github.com/openshift/hive/pull/2438#issuecomment-2326987026): >/override ci/prow/security > >#2387 backport Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

[openshift-ci[bot]]

@2uasimojo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/security	791fd3cd3cfecdfacc412a4d42ecac91d7c150d8	link	true	/test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[2uasimojo]

/assign @dlom

Local test on openstack checked out ✓

[dlom]

/lgtm

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hive/blob/mce-2.4/OWNERS)~~ [2uasimojo,dlom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment