openshift / hive

API driven OpenShift cluster provisioning and management
Apache License 2.0
249 stars 237 forks source link

Azure MachinePool: Add VMNetworkType #2446

Closed 2uasimojo closed 1 month ago

2uasimojo commented 1 month ago

Add MachinePool.Spec.Azure.VMNetworkType to the API. Vendored installer code maps this to MachineSet...ProviderSpec...AcceleratedNetworking:

HIVE-2530

2uasimojo commented 1 month ago

/assign @dlom

Similar to #2415 which you reviewed recently.

dlom commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, dlom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hive/blob/master/OWNERS)~~ [2uasimojo,dlom] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.11%. Comparing base (5a8826b) to head (d6167d0). Report is 7 commits behind head on master.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/hive/pull/2446/graphs/tree.svg?width=650&height=150&src=pr&token=2md6QUue4c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/hive/pull/2446?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## master #2446 +/- ## ========================================== - Coverage 46.28% 46.11% -0.17% ========================================== Files 279 279 Lines 32839 32961 +122 ========================================== + Hits 15199 15200 +1 - Misses 16363 16484 +121 Partials 1277 1277 ``` | [Files with missing lines](https://app.codecov.io/gh/openshift/hive/pull/2446?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [pkg/controller/machinepool/azureactuator.go](https://app.codecov.io/gh/openshift/hive/pull/2446?src=pr&el=tree&filepath=pkg%2Fcontroller%2Fmachinepool%2Fazureactuator.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-cGtnL2NvbnRyb2xsZXIvbWFjaGluZXBvb2wvYXp1cmVhY3R1YXRvci5nbw==) | `68.90% <100.00%> (+0.26%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/openshift/hive/pull/2446/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
2uasimojo commented 1 month ago

/override "Red Hat Konflux / hive-mce-27-on-pull-request" /override "Red Hat Konflux / hive-on-pull-request"

openshift-ci[bot] commented 1 month ago

@2uasimojo: Overrode contexts on behalf of 2uasimojo: Red Hat Konflux / hive-mce-27-on-pull-request, Red Hat Konflux / hive-on-pull-request

In response to [this](https://github.com/openshift/hive/pull/2446#issuecomment-2341912438): >/override "Red Hat Konflux / hive-mce-27-on-pull-request" >/override "Red Hat Konflux / hive-on-pull-request" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

@2uasimojo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).