search

openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
434 stars 319 forks source link

Can we make machineCIDR optional? #318

Closed relyt0925 closed 3 years ago

relyt0925 commented 3 years ago

It for the case of VPC Gen 2 is not a trivial answer to find and is not modeled in ibm-roks-toolkit.

Right now the only placed it's used is in install-config which is used by MCS. But I do not think this CIDR is critical for anything

This is assuming VPN is removed: https://github.com/openshift/hypershift/blob/ba5a814989da5ac0e93d56974d7233eed86331f1/control-plane-operator/controllers/hostedcontrolplane/assets/install-config/install-config.yaml#L6

relyt0925 commented 3 years ago

for now this can lay dormant in ibms config. More important in other cloud providers however so will stay in the main api (we can just pass in the pod cidr here)