openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
434 stars 319 forks source link

Simplify Image Handling #3430

Closed stevekuznetsov closed 5 months ago

stevekuznetsov commented 10 months ago

Right now there are two main causes of confusion and complexity around container images in the repo:

  1. the multitude of ways in which container images may be specified, and their hierarchy a. annotating the HostedCluster b. providing flags to the hypershift-operator c. setting spec fields in the HostedCluster d. self-referential live lookups using the in-cluster client
  2. the fact that the code believes there to be many component images (e.g. for the availability-prober, control-plane-operator, etc) when there is in fact just one

Ideally, we should determine if a) any production environment needs to support multiple component images and, if not, remove that concept as well as b) simplify the many avenues for determining what images are used, and when.

openshift-bot commented 7 months ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 6 months ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 5 months ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 5 months ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/hypershift/issues/3430#issuecomment-2170978970): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.