search

openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
434 stars 319 forks source link

RHCOS MVP: Support dynamic Ignition data on reconcile loop #386

Closed KodieGlosserIBM closed 2 years ago

KodieGlosserIBM commented 3 years ago

When making changes or adding ignition data configmaps the ignition pod should be able to detect changes and dynamically add them on the reconcile loop without the pod needing to restart.

Current reconciliation loop is here: https://github.com/openshift/hypershift/blob/4fc9a8e2c9ecbabc9b1671b4c55951bae6cb019e/ignition-server/controllers/tokensecret_controller.go#L142

We can possibly look to adding something to detect changes as this part when generating the payload.

relyt0925 commented 3 years ago

Think it'll be solved in this PR: https://github.com/openshift/hypershift/pull/357/files

relyt0925 commented 3 years ago

/assign @enxebre

openshift-bot commented 3 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 2 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 2 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 2 years ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/hypershift/issues/386#issuecomment-1003661839): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.