openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
423 stars 313 forks source link

OCPBUGS-37065: OCPBUGS-35899: Doubled machineHealthCheck timeout on Agent and None #4367

Closed jparrill closed 2 months ago

jparrill commented 3 months ago

Manual Cherrypick of:

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/release-4.16/OWNERS)~~ [jparrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 months ago

@jparrill: This pull request references Jira Issue OCPBUGS-35899, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4367): >Manual Cherrypick of: > >- https://github.com/openshift/hypershift/pull/4345 >- https://github.com/openshift/hypershift/pull/4365 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jparrill commented 3 months ago

/jira cherrypick OCPBUGS-35899

openshift-ci-robot commented 3 months ago

@jparrill: Jira Issue OCPBUGS-35899 has been cloned as Jira Issue OCPBUGS-37065. Will retitle bug to link to clone. /retitle OCPBUGS-37065: OCPBUGS-35899: Doubled machineHealthCheck timeout on Agent and None

In response to [this](https://github.com/openshift/hypershift/pull/4367#issuecomment-2229162782): >/jira cherrypick OCPBUGS-35899 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

@jparrill: This pull request references Jira Issue OCPBUGS-37065, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4367): >Manual Cherrypick of: > >- https://github.com/openshift/hypershift/pull/4345 >- https://github.com/openshift/hypershift/pull/4365 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jparrill commented 3 months ago

/retest

jparrill commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@jparrill: This pull request references Jira Issue OCPBUGS-37065, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/hypershift/pull/4367#issuecomment-2230236744): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jparrill commented 3 months ago

/retest

jparrill commented 3 months ago

/retest

jparrill commented 3 months ago

/retest

jparrill commented 3 months ago

/jira backport release-4.15,release-4.14

openshift-ci-robot commented 3 months ago

@jparrill: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges: /cherrypick release-4.15 /cherrypick release-4.14

In response to [this](https://github.com/openshift/hypershift/pull/4367#issuecomment-2232803624): >/jira backport release-4.15,release-4.14 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 3 months ago

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/hypershift/pull/4367#issuecomment-2232804248): >@jparrill: The following backport issues have been created: >- [OCPBUGS-37171](https://issues.redhat.com//browse/OCPBUGS-37171) for branch release-4.15 >- [OCPBUGS-37172](https://issues.redhat.com//browse/OCPBUGS-37172) for branch release-4.14 > >Queuing cherrypicks to the requested branches to be created after this PR merges: >/cherrypick release-4.15 >/cherrypick release-4.14 > >
> >In response to [this](https://github.com/openshift/hypershift/pull/4367#issuecomment-2232803624): > >>/jira backport release-4.15,release-4.14 > > >Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository. >

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

jparrill commented 3 months ago

/retest

jparrill commented 3 months ago

/retest

jparrill commented 3 months ago

/retest

jparrill commented 2 months ago

/retest

jparrill commented 2 months ago

/retest

jparrill commented 2 months ago

/retest

sjenning commented 2 months ago

/lgtm

jparrill commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@jparrill: This pull request references Jira Issue OCPBUGS-37065, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/hypershift/pull/4367#issuecomment-2244639939): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
devguyio commented 2 months ago

/retest

devguyio commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@devguyio: This pull request references Jira Issue OCPBUGS-37065, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/hypershift/pull/4367#issuecomment-2268772664): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

@jparrill: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure fead6ef54d69e1c4f5b5626704de4c69406af903 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
devguyio commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@devguyio: This pull request references Jira Issue OCPBUGS-37065, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-35899](https://issues.redhat.com//browse/OCPBUGS-35899) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-35899](https://issues.redhat.com//browse/OCPBUGS-35899) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @LiangquanLi930

In response to [this](https://github.com/openshift/hypershift/pull/4367#issuecomment-2270797903): >/jira refresh > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@jparrill: Jira Issue OCPBUGS-37065: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-37065 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/hypershift/pull/4367): >Manual Cherrypick of: > >- https://github.com/openshift/hypershift/pull/4345 >- https://github.com/openshift/hypershift/pull/4365 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 2 months ago

@openshift-ci-robot: new pull request created: #4489

In response to [this](https://github.com/openshift/hypershift/pull/4367#issuecomment-2232804248): >@jparrill: The following backport issues have been created: >- [OCPBUGS-37171](https://issues.redhat.com//browse/OCPBUGS-37171) for branch release-4.15 >- [OCPBUGS-37172](https://issues.redhat.com//browse/OCPBUGS-37172) for branch release-4.14 > >Queuing cherrypicks to the requested branches to be created after this PR merges: >/cherrypick release-4.15 >/cherrypick release-4.14 > >
> >In response to [this](https://github.com/openshift/hypershift/pull/4367#issuecomment-2232803624): > >>/jira backport release-4.15,release-4.14 > > >Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository. >

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot commented 2 months ago

@openshift-ci-robot: new pull request created: #4490

In response to [this](https://github.com/openshift/hypershift/pull/4367#issuecomment-2232804248): >@jparrill: The following backport issues have been created: >- [OCPBUGS-37171](https://issues.redhat.com//browse/OCPBUGS-37171) for branch release-4.15 >- [OCPBUGS-37172](https://issues.redhat.com//browse/OCPBUGS-37172) for branch release-4.14 > >Queuing cherrypicks to the requested branches to be created after this PR merges: >/cherrypick release-4.15 >/cherrypick release-4.14 > >
> >In response to [this](https://github.com/openshift/hypershift/pull/4367#issuecomment-2232803624): > >>/jira backport release-4.15,release-4.14 > > >Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository. >

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-merge-robot commented 2 months ago

Fix included in accepted release 4.16.0-0.nightly-2024-08-06-202846