search

openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

NO-JIRA: [release-4.16] test/e2e: remove api budget checks #4368

Closed csrwng closed 1 month ago

csrwng commented 1 month ago

presub e2e's a failing on this again and with no way to quickly diagnose the situation, we should not block PRs on this.

This isn't a great check as the number of mutating calls is somewhat outside our control with delays in cloud resource create/delete contirbuting to long test durations and more mutating calls.

We need a fundamentally better solution here based on KAS audit log analysis.

Manual backport of https://github.com/openshift/hypershift/pull/4286

openshift-ci-robot commented 1 month ago

@csrwng: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/hypershift/pull/4368): >presub e2e's a failing on this again and with no way to quickly diagnose the situation, we should not block PRs on this. > >This isn't a great check as the number of mutating calls is somewhat outside our control with delays in cloud resource create/delete contirbuting to long test durations and more mutating calls. > >We need a fundamentally better solution here based on KAS audit log analysis. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/release-4.16/OWNERS)~~ [csrwng] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sjenning commented 1 month ago

/lgtm

sjenning commented 1 month ago

/test e2e-aws

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD af7332c8e13d800e2666ede70824f3545e284a22 and 2 for PR HEAD d94ca845871119b0a9f7bdbf5f9f1ca05e0d017b in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 16432b82b215d69290d2354e237f77cbfcbaa3bd and 1 for PR HEAD d94ca845871119b0a9f7bdbf5f9f1ca05e0d017b in total

openshift-ci[bot] commented 1 month ago

@csrwng: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure d94ca845871119b0a9f7bdbf5f9f1ca05e0d017b link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.16.0-202407162337.p0.ge9873fd.assembly.stream.el9 for distgit hypershift. All builds following this will include this PR.

sjenning commented 1 month ago

Hit this here as well https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_hypershift/4385/pull-ci-openshift-hypershift-release-4.15-e2e-aws/1813949514063548416

/cherry-pick release-4.15

openshift-cherrypick-robot commented 1 month ago

@sjenning: #4368 failed to apply on top of branch "release-4.15":

Applying: test/e2e: remove api budget checks
Using index info to reconstruct a base tree...
M   test/e2e/e2e_test.go
M   test/e2e/util/hypershift_framework.go
M   test/e2e/util/util.go
Falling back to patching base and 3-way merge...
Auto-merging test/e2e/util/util.go
CONFLICT (content): Merge conflict in test/e2e/util/util.go
Auto-merging test/e2e/util/hypershift_framework.go
Auto-merging test/e2e/e2e_test.go
CONFLICT (content): Merge conflict in test/e2e/e2e_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 test/e2e: remove api budget checks
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/hypershift/pull/4368#issuecomment-2237053613): >Hit this here as well https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_hypershift/4385/pull-ci-openshift-hypershift-release-4.15-e2e-aws/1813949514063548416 > >/cherry-pick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.