openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
423 stars 313 forks source link

[release-4.14] OCPBUGS-37076: Fixed audit-logs sigterm failing to terminate gracefully #4369

Closed heliubj18 closed 1 month ago

heliubj18 commented 3 months ago

This is a manual 4.14 cherry-pick of https://github.com/openshift/hypershift/pull/3972

heliubj18 commented 3 months ago

/jira cherrypick OCPBUGS-33181

openshift-ci-robot commented 3 months ago

@heliubj18: Jira Issue OCPBUGS-33181 has been cloned as Jira Issue OCPBUGS-37076. Will retitle bug to link to clone. /retitle OCPBUGS-37076: [release-4.14] Fixed audit-logs sigterm failing to terminate gracefully

In response to [this](https://github.com/openshift/hypershift/pull/4369#issuecomment-2230001668): >/jira cherrypick OCPBUGS-33181 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

@heliubj18: This pull request references Jira Issue OCPBUGS-37076, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4369): >This is a manual 4.14 cherry-pick of https://github.com/openshift/hypershift/pull/3972 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
heliubj18 commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@heliubj18: This pull request references Jira Issue OCPBUGS-37076, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.z) matches configured target version for branch (4.14.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-34423](https://issues.redhat.com//browse/OCPBUGS-34423) is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-34423](https://issues.redhat.com//browse/OCPBUGS-34423) targets the "4.15.z" version, which is one of the valid target versions: 4.15.0, 4.15.z * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4369#issuecomment-2230010924): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
heliubj18 commented 3 months ago

/assign @rtheis

rtheis commented 3 months ago

/retest-required

heliubj18 commented 3 months ago

/retest-required

bryan-cox commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, heliubj18, rtheis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/release-4.14/OWNERS)~~ [bryan-cox] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

@heliubj18: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-roks 4768da7ad7cf990894a7af7e73ca674e253b6025 link false /test e2e-ibmcloud-roks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD f036a4dbbb9063f20d31e4a0ad0eba3d04968083 and 2 for PR HEAD 4768da7ad7cf990894a7af7e73ca674e253b6025 in total

openshift-ci-robot commented 1 month ago

@heliubj18: Jira Issue OCPBUGS-37076: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-37076 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/hypershift/pull/4369): >This is a manual 4.14 cherry-pick of https://github.com/openshift/hypershift/pull/3972 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-merge-robot commented 1 month ago

Fix included in accepted release 4.14.0-0.nightly-2024-09-05-150839