openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

OCPBUGS-37102: Separate ibmcloud kms encryption configuration types #4372

Closed ryan-cradick closed 1 month ago

ryan-cradick commented 1 month ago

What this PR does / why we need it: Separate ibmcloud kms encryption configuration types to allow enablement of KMS

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story: Fixes # https://issues.redhat.com/browse/OCPBUGS-37102

Checklist

openshift-ci-robot commented 1 month ago

@ryan-cradick: This pull request references Jira Issue OCPBUGS-37102, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4372): >**What this PR does / why we need it**: >Separate ibmcloud kms encryption configuration types to allow enablement of KMS > >**Which issue(s) this PR fixes** *(optional, use `fixes #(, fixes #, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: >Fixes # https://issues.redhat.com/browse/OCPBUGS-37102 > >**Checklist** >- [x] Subject and description added to both, commit and PR. >- [x] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jparrill commented 1 month ago

/approve /retest

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, rtheis, ryan-cradick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [jparrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rtheis commented 1 month ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 1 month ago

@rtheis: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/hypershift/pull/4372#issuecomment-2233179229): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
rtheis commented 1 month ago

/retest-required

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 8d227d69b4b54fe5ba86bab93c7ffe271d982782 and 2 for PR HEAD 7474b4104775a8a2584e3a84761c630aec244df1 in total

openshift-ci[bot] commented 1 month ago

@ryan-cradick: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@ryan-cradick: Jira Issue OCPBUGS-37102: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-37102 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/hypershift/pull/4372): >**What this PR does / why we need it**: >Separate ibmcloud kms encryption configuration types to allow enablement of KMS > >**Which issue(s) this PR fixes** *(optional, use `fixes #(, fixes #, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: >Fixes # https://issues.redhat.com/browse/OCPBUGS-37102 > >**Checklist** >- [x] Subject and description added to both, commit and PR. >- [x] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 1 month ago

@rtheis: new pull request created: #4380

In response to [this](https://github.com/openshift/hypershift/pull/4372#issuecomment-2233179229): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.17.0-202407172141.p0.gae5b096.assembly.stream.el9 for distgit hypershift. All builds following this will include this PR.