search

openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

OSASINFRA-3311: openstack: CAPO provider deployment #4373

Closed EmilienM closed 1 month ago

EmilienM commented 1 month ago

What this PR does / why we need it:

This is the third PR to support OpenStack as dev-preview in 4.17. This PR focuses on the CAPI provider. There are 2 commits:

netlify[bot] commented 1 month ago

Deploy Preview for hypershift-docs ready!

Name Link
Latest commit e3c0d1e9a412f35051737ff70191c7645f43ba3b
Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/669818bee47e52000892e0c7
Deploy Preview https://deploy-preview-4373--hypershift-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

EmilienM commented 1 month ago

/cc csrwng bryan-cox

openshift-ci-robot commented 1 month ago

@EmilienM: This pull request references OSASINFRA-3311 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/hypershift/pull/4373): >**What this PR does / why we need it**: > >- **openstack: add CAPO deployment and OpenStackCluster object** >- **Run `make update`** > >This is the third PR to support OpenStack as dev-preview in 4.17. >This PR focuses on the CAPI provider. There are 2 commits: >* One that reviewers should review `1004 insertions(+), 146 deletions(-)` >* One that was generated by `make update` > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
EmilienM commented 1 month ago

/test unit sounds like a flake in a unrelated test.

EmilienM commented 1 month ago

/test e2e-aks

EmilienM commented 1 month ago

Mostly API comments. We will be going through an effort to mark all API fields as required or optional explicitly; trying to save reworking through these in the future 😄

Thanks, great feedback. We'll keep that in mind for our future API changes. I think I addressed the comments.

bryan-cox commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [bryan-cox] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

@EmilienM: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/hypershift/pull/4373#issuecomment-2234279839): >/retest e2e-azure Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
EmilienM commented 1 month ago

/test e2e-azure

csrwng commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

@EmilienM: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-iks e3c0d1e9a412f35051737ff70191c7645f43ba3b link false /test e2e-ibmcloud-iks
ci/prow/e2e-ibmcloud-roks e3c0d1e9a412f35051737ff70191c7645f43ba3b link false /test e2e-ibmcloud-roks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 2c34df32f7297443bc12f2a52946b74f24c7bdaf and 2 for PR HEAD e3c0d1e9a412f35051737ff70191c7645f43ba3b in total

openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.17.0-202407191140.p0.g6e87ba0.assembly.stream.el9 for distgit hypershift. All builds following this will include this PR.