openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

HOSTEDCP-1832: Document konnectivity in HyperShift #4374

Closed csrwng closed 1 month ago

csrwng commented 1 month ago

What this PR does / why we need it: Adds a more detailed description of Konnectivity and how it's implemented in HyperShift

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story: Fixes #HOSTEDCP-1832

Checklist

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csrwng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [csrwng] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 1 month ago

Deploy Preview for hypershift-docs ready!

Name Link
Latest commit d9ed1eac92af516e356d0599b5ac83f14dcec9f4
Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/6696e3f323ec010009596cfc
Deploy Preview https://deploy-preview-4374--hypershift-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

openshift-ci-robot commented 1 month ago

@csrwng: This pull request references HOSTEDCP-1832 which is a valid jira issue.

In response to [this](https://github.com/openshift/hypershift/pull/4374): >**What this PR does / why we need it**: >Adds a more detailed description of Konnectivity and how it's implemented in HyperShift > >**Which issue(s) this PR fixes** *(optional, use `fixes #(, fixes #, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: >Fixes # > >**Checklist** >- [ ] Subject and description added to both, commit and PR. >- [ ] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@csrwng: This pull request references HOSTEDCP-1832 which is a valid jira issue.

In response to [this](https://github.com/openshift/hypershift/pull/4374): >**What this PR does / why we need it**: >Adds a more detailed description of Konnectivity and how it's implemented in HyperShift > >**Which issue(s) this PR fixes** *(optional, use `fixes #(, fixes #, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: >Fixes #[HOSTEDCP-1832](https://issues.redhat.com/browse/HOSTEDCP-1832) > >**Checklist** >- [ ] Subject and description added to both, commit and PR. >- [ ] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@csrwng: This pull request references HOSTEDCP-1832 which is a valid jira issue.

In response to [this](https://github.com/openshift/hypershift/pull/4374): >**What this PR does / why we need it**: >Adds a more detailed description of Konnectivity and how it's implemented in HyperShift > >**Which issue(s) this PR fixes** *(optional, use `fixes #(, fixes #, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: >Fixes #[HOSTEDCP-1832](https://issues.redhat.com/browse/HOSTEDCP-1832) > >**Checklist** >- [x] Subject and description added to both, commit and PR. >- [x] Relevant issues have been referenced. >- [x] This change includes docs. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sjenning commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

@csrwng: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.17.0-202407170011.p0.ga6f332b.assembly.stream.el9 for distgit hypershift. All builds following this will include this PR.