openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

[WIP] Add ECR credential provider to nodepool controller #4377

Open hectorakemp opened 1 month ago

hectorakemp commented 1 month ago

Resolves https://issues.redhat.com/browse/OSD-24468

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story: Fixes #

Checklist

netlify[bot] commented 1 month ago

Deploy Preview for hypershift-docs ready!

Name Link
Latest commit d4d4f90abd598a39a091aac18b5dc76f7ff2fd81
Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/6697ceb8b9f3ca0008e5a81c
Deploy Preview https://deploy-preview-4377--hypershift-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: hectorakemp Once this PR has been reviewed and has the lgtm label, please assign bryan-cox for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/hypershift/blob/release-4.14/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-merge-robot commented 1 month ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

@hectorakemp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aks d4d4f90abd598a39a091aac18b5dc76f7ff2fd81 link false /test e2e-aks
ci/prow/e2e-azure d4d4f90abd598a39a091aac18b5dc76f7ff2fd81 link false /test e2e-azure
ci/prow/e2e-ibmcloud-roks 9fde636e9509a086969eaecde94fc1114ce1e0f5 link false /test e2e-ibmcloud-roks
ci/prow/e2e-kubevirt-aws-ovn 9fde636e9509a086969eaecde94fc1114ce1e0f5 link true /test e2e-kubevirt-aws-ovn
ci/prow/unit 9fde636e9509a086969eaecde94fc1114ce1e0f5 link true /test unit
ci/prow/verify 9fde636e9509a086969eaecde94fc1114ce1e0f5 link true /test verify
ci/prow/e2e-aws 9fde636e9509a086969eaecde94fc1114ce1e0f5 link true /test e2e-aws
ci/prow/images 9fde636e9509a086969eaecde94fc1114ce1e0f5 link true /test images
ci/prow/e2e-ibmcloud-iks 9fde636e9509a086969eaecde94fc1114ce1e0f5 link false /test e2e-ibmcloud-iks
ci/prow/e2e-kubevirt-aws-ovn-reduced 9fde636e9509a086969eaecde94fc1114ce1e0f5 link true /test e2e-kubevirt-aws-ovn-reduced

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).