Closed a-dsouza closed 1 month ago
@a-dsouza: This pull request references Jira Issue OCPBUGS-36897, which is valid. The bug has been moved to the POST state.
No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.
The bug has been updated to refer to the pull request using the external bug tracker.
@a-dsouza: This pull request references Jira Issue OCPBUGS-36897, which is valid.
No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.
The bug has been updated to refer to the pull request using the external bug tracker.
/retest-required
How about setting a default value of 0 on the .replicas
field to mitigate the issue of old NodePools failing the validation, and preserve the previous behavior.
I don't think it's good to allow both .replicas
or .autoScaling
fields to not be set and rely on implicit defaulting.
@a-dsouza: The following tests failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/e2e-ibmcloud-iks | 2b77a810a46f474257ce06290c9f9561b7bc1d4c | link | false | /test e2e-ibmcloud-iks |
ci/prow/e2e-ibmcloud-roks | 2b77a810a46f474257ce06290c9f9561b7bc1d4c | link | false | /test e2e-ibmcloud-roks |
Full PR test history. Your PR dashboard.
How about setting a default value of 0 on the .replicas field to mitigate the issue of old NodePools failing the validation, and preserve the previous behavior. I don't think it's good to allow both .replicas or .autoScaling fields to not be set and rely on implicit defaulting.
In my mind 0 and nil here have different meanings. If I see replicas=0..N and autoscaler.spec set, I interpret a conflicting intent. So both unset make sense to me. Happy to hear other's thoughts
If I see replicas=0..N and autoscaler.spec set, I interpret a conflicting intent
agreed, this is prevented with the current CEL which I suggest we keep as is. If we add a default only for the replicas field, we satisfy the requirement for people wanting to leave the fields unset but make the behavior of that at least explicit on the API. If the user decides to set spec.autoScaling later on, the current CEL will disallow it.
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: a-dsouza, hasueki, muraee, rtheis
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@a-dsouza: Jira Issue OCPBUGS-36897: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-36897 has been moved to the MODIFIED state.
/cherry-pick release-4.16
@rtheis: new pull request created: #4393
[ART PR BUILD NOTIFIER]
Distgit: hypershift This PR has been included in build ose-hypershift-container-v4.17.0-202407191510.p0.gc84168e.assembly.stream.el9. All builds following this will include this PR.
What this PR does / why we need it: Fixes Nodepool CEL validation to allow neither replicas or autoScaling to be set
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story: Fixes # https://issues.redhat.com/browse/OCPBUGS-36897Checklist