HOSTEDCP-1834: Fix Dependabot Issue By Updating Azure RHCOS Image Copy Process

bryan-cox commented 1 month ago

What this PR does / why we need it: The previous way of copying the RHCOS image from its blob to the blob in the HostedCluster's managed resource group needed to be updated since a previous dependency is no longer available. Specifically, github.com/tombuildsstuff/giovanni/storage/2019-12-12/blob/blobs was removed from GitHub. This process of copying the image also relied on external dependencies versus using Azure SDK functions to copy the RHCOS image. The new process uses only Azure SDK for Go functions to copy the RHCOS image.

Which issue(s) this PR fixes: Fixes HOSTEDCP-1834

Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

openshift-ci-robot commented 1 month ago

@bryan-cox: This pull request references HOSTEDCP-1834 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/hypershift/pull/4379): >**What this PR does / why we need it**: >The previous way of copying the RHCOS image from its blob to the blob in the HostedCluster's managed resource group needed to be updated since a previous dependency is no longer available. Specifically, github.com/tombuildsstuff/giovanni/storage/2019-12-12/blob/blobs was removed from GitHub. This process of copying the image also relied on external dependencies versus using Azure SDK functions to copy the RHCOS image. The new process uses only Azure SDK for Go functions to copy the RHCOS image. > >**Which issue(s) this PR fixes**: >Fixes [HOSTEDCP-1834](https://issues.redhat.com/browse/HOSTEDCP-1834) > >**Checklist** >- [x] Subject and description added to both, commit and PR. >- [x] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [bryan-cox] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

netlify[bot] commented 1 month ago

Deploy Preview for hypershift-docs ready!

Name	Link
Latest commit	a7efa4dc854d86501c235a7986928635e42c1b74
Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/6697f09699e0a90008fdb8fb
Deploy Preview	https://deploy-preview-4379--hypershift-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bryan-cox commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@bryan-cox: This pull request references HOSTEDCP-1834 which is a valid jira issue.

In response to [this](https://github.com/openshift/hypershift/pull/4379#issuecomment-2233718266): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

bryan-cox commented 1 month ago

This is the first issue blocking dependabot from running. The other issue is document here.

bryan-cox commented 1 month ago

/test all

bryan-cox commented 1 month ago

/test unit

bryan-cox commented 1 month ago

/test all

csrwng commented 1 month ago

/lgtm

openshift-ci[bot] commented 1 month ago

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.17.0-202407180441.p0.gd0ff6de.assembly.stream.el9 for distgit hypershift. All builds following this will include this PR.

openshift / hypershift