search

openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

[release-4.16] OCPBUGS-37214: Separate ibmcloud kms encryption configuration types #4380

Closed openshift-cherrypick-robot closed 1 month ago

openshift-cherrypick-robot commented 1 month ago

This is an automated cherry-pick of #4372

/assign rtheis

openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-37102 has been cloned as Jira Issue OCPBUGS-37214. Will retitle bug to link to clone. /retitle [release-4.16] OCPBUGS-37214: Separate ibmcloud kms encryption configuration types

In response to [this](https://github.com/openshift/hypershift/pull/4380): >This is an automated cherry-pick of #4372 > >/assign rtheis Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-37214, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4380): >This is an automated cherry-pick of #4372 > >/assign rtheis Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rtheis commented 1 month ago

/retest

rtheis commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@rtheis: This pull request references Jira Issue OCPBUGS-37214, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/hypershift/pull/4380#issuecomment-2236173060): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
enxebre commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, openshift-cherrypick-robot, rtheis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/release-4.16/OWNERS)~~ [enxebre] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
enxebre commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@enxebre: This pull request references Jira Issue OCPBUGS-37214, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/hypershift/pull/4380#issuecomment-2239274847): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
enxebre commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@enxebre: This pull request references Jira Issue OCPBUGS-37214, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/hypershift/pull/4380#issuecomment-2239276753): >/jira refresh > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rtheis commented 1 month ago

@ryan-cradick how do we get the fix on main verified faster so we can proceed with this PR?

ryan-cradick commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@ryan-cradick: This pull request references Jira Issue OCPBUGS-37214, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-37102](https://issues.redhat.com//browse/OCPBUGS-37102) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-37102](https://issues.redhat.com//browse/OCPBUGS-37102) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/hypershift/pull/4380#issuecomment-2245662237): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rtheis commented 1 month ago

@enxebre are we able to retrigger the Red Hat Konflux check?

Patryk-Stefanski commented 1 month ago

/retest

Patryk-Stefanski commented 1 month ago

/override "Red Hat Konflux / hypershift-release-mce-26-on-pull-request"

openshift-ci[bot] commented 1 month ago

@Patryk-Stefanski: Patryk-Stefanski unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

In response to [this](https://github.com/openshift/hypershift/pull/4380#issuecomment-2250355130): > >/override "Red Hat Konflux / hypershift-release-mce-26-on-pull-request" > > Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
bryan-cox commented 1 month ago

/override "Red Hat Konflux / hypershift-release-mce-26-on-pull-request"

openshift-ci[bot] commented 1 month ago

@bryan-cox: Overrode contexts on behalf of bryan-cox: Red Hat Konflux / hypershift-release-mce-26-on-pull-request

In response to [this](https://github.com/openshift/hypershift/pull/4380#issuecomment-2250358129): >/override "Red Hat Konflux / hypershift-release-mce-26-on-pull-request" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-37214: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-37214 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/hypershift/pull/4380): >This is an automated cherry-pick of #4372 > >/assign rtheis Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: hypershift This PR has been included in build ose-hypershift-container-v4.16.0-202407251807.p0.gbc392bb.assembly.stream.el9. All builds following this will include this PR.