Closed csrwng closed 1 month ago
@csrwng: This pull request references Jira Issue OCPBUGS-36932, which is invalid:
Comment /jira refresh
to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.
The bug has been updated to refer to the pull request using the external bug tracker.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: csrwng
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/test e2e-conformance
/jira refresh
@csrwng: This pull request references Jira Issue OCPBUGS-36932, which is valid. The bug has been moved to the POST state.
No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.
Name | Link |
---|---|
Latest commit | cac8cf412e7b760fe7374f94765564669a81b7c8 |
Latest deploy log | https://app.netlify.com/sites/hypershift-docs/deploys/669adbeb47b42300086537b8 |
Deploy Preview | https://deploy-preview-4381--hypershift-docs.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/lgtm
/lgtm
/retest-required
Remaining retests: 0 against base HEAD fd652e260a454361bf2775978422a8ec1f1622b0 and 2 for PR HEAD da86b6b93b5ace669b2cb882d8b18b07200fd433 in total
/retest-required
Remaining retests: 0 against base HEAD 4cc5965900ca355f5cbc9a75879228163d07f20e and 1 for PR HEAD da86b6b93b5ace669b2cb882d8b18b07200fd433 in total
@csrwng: all tests passed!
Full PR test history. Your PR dashboard.
@csrwng: Jira Issue OCPBUGS-36932: All pull requests linked via external trackers have merged:
Jira Issue OCPBUGS-36932 has been moved to the MODIFIED state.
[ART PR BUILD NOTIFIER]
Distgit: hypershift This PR has been included in build ose-hypershift-container-v4.18.0-202407311041.p0.g4a34cb8.assembly.stream.el9. All builds following this will include this PR.
/cherry-pick release-4.16
/cherry-pick release-4.15
@csrwng: new pull request created: #4496
@csrwng: new pull request created: #4497
What this PR does / why we need it: The socks5 konnectivity proxy does not honor user-configured HTTP/S proxies when sending traffic through the dataplane. Most identity providers handled by the OAuth server do use HTTP/S for external communication and should honor any user configured proxy. This commit adds an additional container to the oauth server deployment with the HTTP konnectivity proxy. This proxy does honor the user-configured HTTP/S proxy for the HostedCluster when sending traffic through the data plane. The socks5 proxy is still used for the LDAP identity provider which does not use the proxy for its traffic. On the OAuth server, the HTTP_PROXY and HTTPS_PROXY environment variables point to the HTTP proxy while the ALL_PROXY variable still points to the socks5 proxy.
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story: Fixes #OCPBUGS-36932Checklist