openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
423 stars 313 forks source link

OCPBUGS-37222: extract rhel9 MCO binaries for rhel8 based MCO images #4382

Closed sjenning closed 3 months ago

sjenning commented 3 months ago

Dynamically use rhel9 MCO binaries for rhel8 based MCO images

xref https://github.com/openshift/machine-config-operator/pull/4476

openshift-ci-robot commented 3 months ago

@sjenning: This pull request references Jira Issue OCPBUGS-36863, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4382): >Dynamically use rhel9 MCO binaries for rhel8 based MCO images > >xref https://github.com/openshift/machine-config-operator/pull/4476 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [sjenning] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 months ago

@sjenning: This pull request references Jira Issue OCPBUGS-37222, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4382): >Dynamically use rhel9 MCO binaries for rhel8 based MCO images > >xref https://github.com/openshift/machine-config-operator/pull/4476 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sjenning commented 3 months ago

/test e2e-aws

enxebre commented 3 months ago

/lgtm

openshift-ci[bot] commented 3 months ago

@sjenning: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 3 months ago

@sjenning: Jira Issue OCPBUGS-37222: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-37222 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/hypershift/pull/4382): >Dynamically use rhel9 MCO binaries for rhel8 based MCO images > >xref https://github.com/openshift/machine-config-operator/pull/4476 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
celebdor commented 3 months ago

/cherry-pick release-4.16 release-4.15 release-4.14

openshift-cherrypick-robot commented 3 months ago

@celebdor: new pull request created: #4383

In response to [this](https://github.com/openshift/hypershift/pull/4382#issuecomment-2236254292): >/cherry-pick release-4.16 release-4.15 release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.17.0-202407181340.p0.g4ceb74b.assembly.stream.el9 for distgit hypershift. All builds following this will include this PR.