search

openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

NO-JIRA: Refactor Ensure... functions starting with EnsureNoCrashingPods #4386

Open jparrill opened 1 month ago

jparrill commented 1 month ago

Refactored EnsureNoCrashingPods as a first step to use an standard interface for all Ensure functions

openshift-ci-robot commented 1 month ago

@jparrill: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/hypershift/pull/4386): >Refactored EnsureNoCrashingPods as a first step to use an standard interface for all Ensure functions Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [jparrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jparrill commented 1 month ago

/test unit

openshift-ci[bot] commented 1 month ago

@jparrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
bryan-cox commented 1 month ago

This looks like a large enough change that it should have its own Jira ticket IMO.

Is this related to some epic or feature about refactoring e2e's?

jparrill commented 1 month ago

This looks like a large enough change that it should have its own Jira ticket IMO.

Is this related to some epic or feature about refactoring e2e's?

Yes, this is why I only put the first piece :). I don't think there is any Jira regarding this refactor but I think that the Ensure trigger function will help to make lighter the CI.

openshift-merge-robot commented 1 month ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.