Open jparrill opened 1 month ago
@jparrill: This pull request explicitly references no jira issue.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jparrill
The full list of commands accepted by this bot can be found here.
The pull request process is described here
Name | Link |
---|---|
Latest commit | e65d5c3cc5050de8840476b72597ca7ee965fe54 |
Latest deploy log | https://app.netlify.com/sites/hypershift-docs/deploys/669a2a06dc691b000884985d |
Deploy Preview | https://deploy-preview-4388--hypershift-docs.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
/test unit
This looks like a large enough change that it should have its own Jira ticket IMO.
Is this related to some epic or feature about refactoring e2e's?
/retest
This looks like a large enough change that it should have its own Jira ticket IMO.
Is this related to some epic or feature about refactoring e2e's?
Not yet, was part of a PoC I've started on the Shift Week, so I think I can share with the rest of the team at some point and, if all agree and makes sense, create the epic a go with that.
@jparrill: all tests passed!
Full PR test history. Your PR dashboard.
PR needs rebase.
This script registers the EnsureXXX functions used usually in E2E tests and triggers it from local agains a Management or HostedCluster already created. The tipical EnsureXXX functions need to be moved to e2eutil.EnsureFuncs type in order to honor the interface contract. The PR https://github.com/openshift/hypershift/pull/4386 is the first step and the current PR depends on it.