openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

NO-JIRA: Script to trigger Ensure functions from local #4388

Open jparrill opened 1 month ago

jparrill commented 1 month ago

This script registers the EnsureXXX functions used usually in E2E tests and triggers it from local agains a Management or HostedCluster already created. The tipical EnsureXXX functions need to be moved to e2eutil.EnsureFuncs type in order to honor the interface contract. The PR https://github.com/openshift/hypershift/pull/4386 is the first step and the current PR depends on it.

openshift-ci-robot commented 1 month ago

@jparrill: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/hypershift/pull/4388): >This script registers the EnsureXXX functions used usually in E2E tests and triggers it from local agains a Management or HostedCluster already created. The tipical EnsureXXX functions need to be moved to e2eutil.EnsureFuncs type in order to honor the interface contract. The PR https://github.com/openshift/hypershift/pull/4386 is the first step and the current PR depends on it. > >- Depends on https://github.com/openshift/hypershift/pull/4386. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [jparrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 1 month ago

Deploy Preview for hypershift-docs ready!

Name Link
Latest commit e65d5c3cc5050de8840476b72597ca7ee965fe54
Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/669a2a06dc691b000884985d
Deploy Preview https://deploy-preview-4388--hypershift-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jparrill commented 1 month ago

/test unit

bryan-cox commented 1 month ago

This looks like a large enough change that it should have its own Jira ticket IMO.

Is this related to some epic or feature about refactoring e2e's?

jparrill commented 1 month ago

/retest

jparrill commented 1 month ago

This looks like a large enough change that it should have its own Jira ticket IMO.

Is this related to some epic or feature about refactoring e2e's?

Not yet, was part of a PoC I've started on the Shift Week, so I think I can share with the rest of the team at some point and, if all agree and makes sense, create the epic a go with that.

openshift-ci[bot] commented 1 month ago

@jparrill: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-merge-robot commented 1 month ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.