search

openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

[release-4.16] OCPBUGS-37302: fix(api): Nodepool CEL validation fix #4395

Closed hasueki closed 1 month ago

hasueki commented 1 month ago

What this PR does / why we need it: Supersedes https://github.com/openshift/hypershift/pull/4393

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story: Fixes #

Checklist

openshift-ci-robot commented 1 month ago

@hasueki: This pull request references Jira Issue OCPBUGS-37302, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4395): >**What this PR does / why we need it**: >Supersedes https://github.com/openshift/hypershift/pull/4393 > >**Which issue(s) this PR fixes** *(optional, use `fixes #(, fixes #, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: >Fixes # > >**Checklist** >- [ ] Subject and description added to both, commit and PR. >- [ ] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
hasueki commented 1 month ago

/retest-required

sjenning commented 1 month ago

/approve /lgtm

rtheis commented 1 month ago

/retest-required

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasueki, rtheis, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/release-4.16/OWNERS)~~ [sjenning] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
rtheis commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@rtheis: This pull request references Jira Issue OCPBUGS-37302, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/hypershift/pull/4395#issuecomment-2241086835): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rtheis commented 1 month ago

@hasueki how do we get the fix on main verified faster so we can proceed with this PR?

hasueki commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@hasueki: This pull request references Jira Issue OCPBUGS-37302, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-36897](https://issues.redhat.com//browse/OCPBUGS-36897) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-36897](https://issues.redhat.com//browse/OCPBUGS-36897) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/hypershift/pull/4395#issuecomment-2245728676): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rtheis commented 1 month ago

@hasueki are we able to bypass the Red Hat Konflux check?

hasueki commented 1 month ago

/retest-required

hasueki commented 1 month ago

/retest

bryan-cox commented 1 month ago

/override "Red Hat Konflux / hypershift-release-mce-26-on-pull-request"

openshift-ci[bot] commented 1 month ago

@bryan-cox: Overrode contexts on behalf of bryan-cox: Red Hat Konflux / hypershift-release-mce-26-on-pull-request

In response to [this](https://github.com/openshift/hypershift/pull/4395#issuecomment-2245829268): >/override "Red Hat Konflux / hypershift-release-mce-26-on-pull-request" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 1 month ago

@hasueki: Jira Issue OCPBUGS-37302: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-37302 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/hypershift/pull/4395): >**What this PR does / why we need it**: >Supersedes https://github.com/openshift/hypershift/pull/4393 > >**Which issue(s) this PR fixes** *(optional, use `fixes #(, fixes #, ...)` format, where issue_number might be a GitHub issue, or a Jira story*: >Fixes # > >**Checklist** >- [ ] Subject and description added to both, commit and PR. >- [ ] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: hypershift This PR has been included in build ose-hypershift-container-v4.16.0-202407231906.p0.gbdf469e.assembly.stream.el9. All builds following this will include this PR.

openshift-merge-robot commented 1 month ago

Fix included in accepted release 4.16.0-0.nightly-2024-07-23-215437