Closed EmilienM closed 1 month ago
@EmilienM: This pull request references OSASINFRA-3538 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.
/cc bryan-cox csrwng
sorry I had to fix unit tests and I missed something in the product CLI. This is ready for review now. Thanks!
/cc MaysaMacedo
Looks like there is a missing unit test for CreateCluster as well? AWS example - https://github.com/openshift/hypershift/blob/c40225a6155171291734f837f353fadf387bf463/cmd/cluster/aws/create_test.go#L123
Looks like there is a missing unit test for CreateCluster as well? AWS example -
done!
/test e2e-azure e2e-aks e2e-aws
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bryan-cox, EmilienM
The full list of commands accepted by this bot can be found here.
The pull request process is described here
/lgtm
/test e2e-aks
/test e2e-azure
@EmilienM: The following test failed, say /retest
to rerun all failed tests or /retest-required
to rerun all mandatory failed tests:
Test name | Commit | Details | Required | Rerun command |
---|---|---|---|---|
ci/prow/e2e-azure | ad3d2cd0b313fca8eb57b14258b6bf63b6eba942 | link | false | /test e2e-azure |
Full PR test history. Your PR dashboard.
[ART PR BUILD NOTIFIER]
Distgit: hypershift This PR has been included in build ose-hypershift-container-v4.17.0-202407231713.p0.g05a7a25.assembly.stream.el9. All builds following this will include this PR.
What this PR does / why we need it: