openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

OSASINFRA-3538: openstack: cluster CLI #4396

Closed EmilienM closed 1 month ago

EmilienM commented 1 month ago

What this PR does / why we need it:

openshift-ci-robot commented 1 month ago

@EmilienM: This pull request references OSASINFRA-3538 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/hypershift/pull/4396): >**What this PR does / why we need it**: > >* Basic CLI options for cluster create & destroy. More options > will come with Node pools and in the future with more usecases. >* Set a default Machine Network when creating the cluster with the CLI. >* Add the CLI options to e2e. > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
EmilienM commented 1 month ago

/cc bryan-cox csrwng

EmilienM commented 1 month ago

sorry I had to fix unit tests and I missed something in the product CLI. This is ready for review now. Thanks!

EmilienM commented 1 month ago

/cc MaysaMacedo

bryan-cox commented 1 month ago

Looks like there is a missing unit test for CreateCluster as well? AWS example - https://github.com/openshift/hypershift/blob/c40225a6155171291734f837f353fadf387bf463/cmd/cluster/aws/create_test.go#L123

EmilienM commented 1 month ago

Looks like there is a missing unit test for CreateCluster as well? AWS example -

https://github.com/openshift/hypershift/blob/c40225a6155171291734f837f353fadf387bf463/cmd/cluster/aws/create_test.go#L123

done!

EmilienM commented 1 month ago

/test e2e-azure e2e-aks e2e-aws

bryan-cox commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, EmilienM

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [bryan-cox] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
MaysaMacedo commented 1 month ago

/lgtm

EmilienM commented 1 month ago

/test e2e-aks

EmilienM commented 1 month ago

/test e2e-azure

openshift-ci[bot] commented 1 month ago

@EmilienM: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure ad3d2cd0b313fca8eb57b14258b6bf63b6eba942 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: hypershift This PR has been included in build ose-hypershift-container-v4.17.0-202407231713.p0.g05a7a25.assembly.stream.el9. All builds following this will include this PR.