openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

WIP: Azure: implement private KAS endpoint support using private link #4397

Open muraee opened 1 month ago

muraee commented 1 month ago

What this PR does / why we need it:

This adds support to deploy azure clusters with private apiservers accessbile only from the private network. For this a new internal load balancer for the shared-ingress router and an associated private link service with enabled proxy protocol is created. Each azure private cluster will create a private endpoints and connect to the shared-ingress private link service. Connections going through the private link will have a linkID in the proxy header which is extracted by the shared-ingress router and used to decide which cluster's KAS the request will be routed to.

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story: Fixes #

Checklist

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [muraee] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
netlify[bot] commented 1 month ago

Deploy Preview for hypershift-docs ready!

Name Link
Latest commit 73e3248ecec1ad9b2e5c1601f0187b9f663b9d25
Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/66d983372b23550008d3edaa
Deploy Preview https://deploy-preview-4397--hypershift-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

openshift-ci[bot] commented 1 day ago

@muraee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud-roks 3c4ad1287974c142350f1c17ccd9bd10c8c86cf1 link false /test e2e-ibmcloud-roks
ci/prow/e2e-ibmcloud-iks 3c4ad1287974c142350f1c17ccd9bd10c8c86cf1 link false /test e2e-ibmcloud-iks
ci/prow/e2e-azure 3c4ad1287974c142350f1c17ccd9bd10c8c86cf1 link false /test e2e-azure
ci/prow/e2e-aks 9e58be86f70f9ce1c83fc7befbac14155e9d604f link true /test e2e-aks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).