search

openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

[release-4.16] OCPBUGS-30282: Multiple MachineConfigs in one CM #4398

Closed michael-topchiev closed 1 month ago

michael-topchiev commented 1 month ago

This PR is a manual cherry-pick of https://github.com/openshift/hypershift/pull/3695 into branch release-4.16 because automatic /cherry-pick failed due to a code conflict.

openshift-ci-robot commented 1 month ago

@michael-topchiev: This pull request references Jira Issue OCPBUGS-30282, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/hypershift/pull/4398): >This PR is a manual cherry-pick of https://github.com/openshift/hypershift/pull/3695 into branch `release-4.16` because automatic `/cherry-pick` failed due to a code conflict. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
michael-topchiev commented 1 month ago

/retest-required

michael-topchiev commented 1 month ago

/retest-required

michael-topchiev commented 1 month ago

/retest-required

michael-topchiev commented 1 month ago

/retest-required

michael-topchiev commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@michael-topchiev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 7d01c1329bd0bb0c115f3d40846f87d027fe2105 link false /test e2e-azure
ci/prow/e2e-ibmcloud-iks 7d01c1329bd0bb0c115f3d40846f87d027fe2105 link false /test e2e-ibmcloud-iks
ci/prow/e2e-ibmcloud-roks 7d01c1329bd0bb0c115f3d40846f87d027fe2105 link false /test e2e-ibmcloud-roks

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jparrill commented 1 month ago

You need to fix the release note :).

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill, michael-topchiev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/release-4.16/OWNERS)~~ [jparrill] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
michael-topchiev commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@michael-topchiev: This pull request references Jira Issue OCPBUGS-30282, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/hypershift/pull/4398#issuecomment-2255916439): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
hasueki commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@hasueki: This pull request references Jira Issue OCPBUGS-30282, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/hypershift/pull/4398#issuecomment-2255952750): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
michael-topchiev commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@michael-topchiev: This pull request references Jira Issue OCPBUGS-30282, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-37715](https://issues.redhat.com//browse/OCPBUGS-37715) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-37715](https://issues.redhat.com//browse/OCPBUGS-37715) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (jiezhao@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/hypershift/pull/4398#issuecomment-2259165891): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
michael-topchiev commented 1 month ago

@jparrill the release note is fixed now

enxebre commented 1 month ago

/lgtm

openshift-ci-robot commented 1 month ago

@michael-topchiev: Jira Issue OCPBUGS-30282: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30282 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/hypershift/pull/4398): >This PR is a manual cherry-pick of https://github.com/openshift/hypershift/pull/3695 into branch `release-4.16` because automatic `/cherry-pick` failed due to a code conflict. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: hypershift This PR has been included in build ose-hypershift-container-v4.16.0-202408011039.p0.g4ed1c2c.assembly.stream.el9. All builds following this will include this PR.