openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

OSASINFRA-3539: Add ipam to cluster-api assets #4399

Closed MaysaMacedo closed 1 month ago

MaysaMacedo commented 1 month ago

This commit adds ipam to cluster-api assets and to the hypershift API scheme. This resource is needed by openstackfloatingippool in the cluster-api-provider-openstack.

openshift-ci-robot commented 1 month ago

@MaysaMacedo: This pull request references OSASINFRA-3539 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/hypershift/pull/4399): >This commit adds ipam assets to cluster-api, >which are needed for openstackfloatingippool >resource in the cluster-api-provider-openstack. > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
EmilienM commented 1 month ago

/lgtm Thanks

bryan-cox commented 1 month ago

nit: the commit message should use the imperative mood - see 4) here for more details

openshift-ci-robot commented 1 month ago

@MaysaMacedo: This pull request references OSASINFRA-3539 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/hypershift/pull/4399): >This commit adds ipam to cluster-api assets >and to the hypershift API scheme. This resource >is needed by openstackfloatingippool in the >cluster-api-provider-openstack. > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
netlify[bot] commented 1 month ago

Deploy Preview for hypershift-docs ready!

Name Link
Latest commit ec2cadf893a4852b536875b145fd5e47d35a68c3
Latest deploy log https://app.netlify.com/sites/hypershift-docs/deploys/669e5bc942dc6e00080a6308
Deploy Preview https://deploy-preview-4399--hypershift-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

MaysaMacedo commented 1 month ago

@bryan-cox ack, thanks! The PR is ready for another look.

bryan-cox commented 1 month ago

/retest

EmilienM commented 1 month ago

/lgtm

bryan-cox commented 1 month ago

/retest

For konflux

EmilienM commented 1 month ago

/test e2e-azure

bryan-cox commented 1 month ago

/approve

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox, MaysaMacedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [bryan-cox] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

@MaysaMacedo: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: hypershift This PR has been included in build ose-hypershift-container-v4.18.0-202407232010.p0.g933f5f2.assembly.stream.el9. All builds following this will include this PR.