Closed MaysaMacedo closed 1 month ago
@MaysaMacedo: This pull request references OSASINFRA-3539 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.
/lgtm Thanks
nit: the commit message should use the imperative mood - see 4) here for more details
@MaysaMacedo: This pull request references OSASINFRA-3539 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.
Name | Link |
---|---|
Latest commit | ec2cadf893a4852b536875b145fd5e47d35a68c3 |
Latest deploy log | https://app.netlify.com/sites/hypershift-docs/deploys/669e5bc942dc6e00080a6308 |
Deploy Preview | https://deploy-preview-4399--hypershift-docs.netlify.app |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
@bryan-cox ack, thanks! The PR is ready for another look.
/retest
/lgtm
/retest
For konflux
/test e2e-azure
/approve
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: bryan-cox, MaysaMacedo
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@MaysaMacedo: all tests passed!
Full PR test history. Your PR dashboard.
[ART PR BUILD NOTIFIER]
Distgit: hypershift This PR has been included in build ose-hypershift-container-v4.18.0-202407232010.p0.g933f5f2.assembly.stream.el9. All builds following this will include this PR.
This commit adds ipam to cluster-api assets and to the hypershift API scheme. This resource is needed by openstackfloatingippool in the cluster-api-provider-openstack.