search

openshift / hypershift

Hyperscale OpenShift - clusters with hosted control planes
https://hypershift-docs.netlify.app
Apache License 2.0
414 stars 308 forks source link

HOSTEDCP-1838: Migrate buildah config in tekton files for migration from 0.1 to 0.2 #4403

Closed bryan-cox closed 1 month ago

bryan-cox commented 1 month ago

What this PR does / why we need it: This PR:

Which issue(s) this PR fixes: Fixes HOSTEDCP-1838

Checklist

openshift-ci-robot commented 1 month ago

@bryan-cox: This pull request references HOSTEDCP-1838 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/hypershift/pull/4403): >**What this PR does / why we need it**: >This PR: >* Cherry-picks https://github.com/openshift/hypershift/pull/4400 >* Updates the buildah config in the tekton files per https://github.com/konflux-ci/build-definitions/blob/main/task/buildah/0.2/MIGRATION.md > >**Which issue(s) this PR fixes**: >Fixes [HOSTEDCP-1838](https://issues.redhat.com/browse/HOSTEDCP-1838) > >**Checklist** >- [x] Subject and description added to both, commit and PR. >- [x] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [bryan-cox] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
bryan-cox commented 1 month ago

/area ci-tooling

openshift-ci[bot] commented 1 month ago

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
bryan-cox commented 1 month ago

/retest

csrwng commented 1 month ago

/lgtm

openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: hypershift This PR has been included in build ose-hypershift-container-v4.17.0-202407222110.p0.gb09d987.assembly.stream.el9. All builds following this will include this PR.