HOSTEDCP-1798: Refactor multi-arch validation algorithm

bryan-cox commented 2 months ago

What this PR does / why we need it: Refactors the algorithm performing different multi-arch validations similar to this.

Which issue(s) this PR fixes: Fixes HOSTEDCP-1778

Checklist

[x] Subject and description added to both, commit and PR.
[x] Relevant issues have been referenced.
[ ] This change includes docs.
[ ] This change includes unit tests.

openshift-ci-robot commented 2 months ago

@bryan-cox: This pull request references HOSTEDCP-1778 which is a valid jira issue.

In response to [this](https://github.com/openshift/hypershift/pull/4405): >**What this PR does / why we need it**: >Refactors the algorithm performing different multi-arch validations similar to [this](https://excalidraw.com/#json=QeumxPAwNmXPFxe4GjuWt,I_h08v5-INft4lOLYO5Mcg). > >**Which issue(s) this PR fixes**: >Fixes [HOSTEDCP-1778](https://issues.redhat.com/browse/HOSTEDCP-1778) > >**Checklist** >- [x] Subject and description added to both, commit and PR. >- [x] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci[bot] commented 2 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/hypershift/blob/main/OWNERS)~~ [bryan-cox] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

bryan-cox commented 2 months ago

I did not implement this block from the drawing as I don't recall why we originally needed it

 if multi-arch flag set 
        warn user multi-arch image not used,
        block hc creation

netlify[bot] commented 2 months ago

Deploy Preview for hypershift-docs ready!

Name	Link
Latest commit	85936dcb0c464fc051129142626208684294b706
Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/669ebc81742ae10008cddedc
Deploy Preview	https://deploy-preview-4405--hypershift-docs.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

bryan-cox commented 2 months ago

/test all

bryan-cox commented 2 months ago

/retest

bryan-cox commented 2 months ago

/test e2e-aks

bryan-cox commented 2 months ago

/test e2e-aks

bryan-cox commented 2 months ago

/test e2e-aks

muraee commented 2 months ago

/lgtm

openshift-ci-robot commented 2 months ago

@bryan-cox: This pull request references HOSTEDCP-1798 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/hypershift/pull/4405): >**What this PR does / why we need it**: >Refactors the algorithm performing different multi-arch validations similar to [this](https://excalidraw.com/#json=QeumxPAwNmXPFxe4GjuWt,I_h08v5-INft4lOLYO5Mcg). > >**Which issue(s) this PR fixes**: >Fixes [HOSTEDCP-1778](https://issues.redhat.com/browse/HOSTEDCP-1778) > >**Checklist** >- [x] Subject and description added to both, commit and PR. >- [x] Relevant issues have been referenced. >- [ ] This change includes docs. >- [ ] This change includes unit tests. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

bryan-cox commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@bryan-cox: This pull request references HOSTEDCP-1798 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/hypershift/pull/4405#issuecomment-2252465840): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

bryan-cox commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@bryan-cox: This pull request references HOSTEDCP-1798 which is a valid jira issue.

In response to [this](https://github.com/openshift/hypershift/pull/4405#issuecomment-2252466691): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fhypershift). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci[bot] commented 2 months ago

@bryan-cox: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure	31ead4c8609c1979deb8687deb2d2a53b724df73	link	false	`/test e2e-azure`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: hypershift This PR has been included in build ose-hypershift-container-v4.18.0-202407261545.p0.gcbbf421.assembly.stream.el9. All builds following this will include this PR.

openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

Distgit: hypershift This PR has been included in build ose-hypershift-container-v4.17.0-202407261545.p0.gcbbf421.assembly.stream.el9. All builds following this will include this PR.

openshift / hypershift